Expose shouldRecycle property of vertical-collection #648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The shouldRecycle property of
vertical-collectionneeds to be set to false in our app in order for the occlusion rendering to work due to our use of components within the table rows. This PR exposes the shouldRecycle property to apps so that it can be set to false if required.shouldRecycle is defined here: https://github.com/html-next/vertical-collection/blob/37a88794f5ecc2e31abe76577d2f32db47a05b51/addon/components/vertical-collection/component.js#L81