Sync eslint & prettier in test-app-3.x (like in other test-apps…

…) & fix test errors

test-app-3.x/.eslintignore

@@ -0,0 +1,14 @@
+# unconventional js
+/blueprints/*/files/
+
+# compiled output
+/declarations/
+/dist/
+
+# misc
+/coverage/
+!.*
+.*/
+
+# ember-try
+/.node_modules.ember-try/

test-app-3.x/.eslintrc.js

@@ -2,12 +2,15 @@
 
 module.exports = {
   root: true,
-  parser: 'babel-eslint',
+  parser: '@babel/eslint-parser',
   parserOptions: {
-    ecmaVersion: 2018,
+    ecmaVersion: 'latest',
     sourceType: 'module',
-    ecmaFeatures: {
-      legacyDecorators: true,
+    requireConfigFile: false,
+    babelOptions: {
+      plugins: [
+        ['@babel/plugin-proposal-decorators', { decoratorsBeforeExport: true }],
+      ],
     },
   },
   plugins: ['ember'],
@@ -26,31 +29,31 @@ module.exports = {
       files: [
         './.eslintrc.js',
         './.prettierrc.js',
+        './.stylelintrc.js',
         './.template-lintrc.js',
         './ember-cli-build.js',
         './testem.js',
         './blueprints/*/index.js',
         './config/**/*.js',
         './lib/*/index.js',
         './server/**/*.js',
-        './scenarios.js',
-        './tests/.eslintrc.js',
       ],
-      excludedFiles: ['addon/**', 'addon-test-support/**', 'app/**'],
       parserOptions: {
         sourceType: 'script',
       },
       env: {
         browser: false,
         node: true,
       },
-      plugins: ['node'],
-      extends: ['plugin:node/recommended'],
+      extends: ['plugin:n/recommended'],
     },
     {
-      // Test files:
+      // test files
       files: ['tests/**/*-test.{js,ts}'],
       extends: ['plugin:qunit/recommended'],
+      rules: {
+        'qunit/require-expect': 'off',
+      },
     },
   ],
 };

test-app-3.x/.prettierignore

@@ -0,0 +1,13 @@
+# unconventional js
+/blueprints/*/files/
+
+# compiled output
+/dist/
+
+# misc
+/coverage/
+!.*
+.*/
+
+# ember-try
+/.node_modules.ember-try/

test-app-3.x/.prettierrc.js

@@ -0,0 +1,12 @@
+'use strict';
+
+module.exports = {
+  overrides: [
+    {
+      files: '*.{js,ts}',
+      options: {
+        singleQuote: true,
+      },
+    },
+  ],
+};

test-app-3.x/.stylelintignore

@@ -0,0 +1,8 @@
+# unconventional files
+/blueprints/*/files/
+
+# compiled output
+/dist/
+
+# addons
+/.node_modules.ember-try/

test-app-3.x/package.json

@@ -19,6 +19,7 @@
     "test:ember": "ember test --test-port 0"
   },
   "devDependencies": {
+    "@babel/eslint-parser": "^7.24.7",
     "@ember/optional-features": "^2.0.0",
     "@ember/test-helpers": "^2.6.0",
     "@ember/string": "^3.1.1",
@@ -46,16 +47,16 @@
     "ember-source-channel-url": "^3.0.0",
     "ember-template-lint": "^3.15.0",
     "ember-try": "^3.0.0",
-    "eslint": "^7.32.0",
-    "eslint-config-prettier": "^8.3.0",
-    "eslint-plugin-ember": "^10.5.8",
-    "eslint-plugin-node": "^11.1.0",
-    "eslint-plugin-prettier": "^3.4.1",
-    "eslint-plugin-qunit": "^6.2.0",
+    "eslint": "^8.57.0",
+    "eslint-config-prettier": "^9.1.0",
+    "eslint-plugin-ember": "^11.12.0",
+    "eslint-plugin-n": "^16.6.2",
+    "eslint-plugin-prettier": "^5.1.3",
+    "eslint-plugin-qunit": "^8.1.1",
     "jquery": "^3.6.0",
     "loader.js": "^4.7.0",
     "moment-timezone": "^0.5.33",
-    "prettier": "^2.5.1",
+    "prettier": "^3.3.2",
     "qunit": "^2.17.2",
     "qunit-console-grouper": "^0.3.0",
     "qunit-dom": "^1.6.0",

test-app-3.x/tests/integration/moment-test.js

@@ -41,7 +41,7 @@ module('moment', function (hooks) {
     });
 
     await render(
-      hbs`{{moment-format (moment this.date this.inputFormat) this.outputFormat}}`
+      hbs`{{moment-format (moment this.date this.inputFormat) this.outputFormat}}`,
     );
     assert.dom(this.element).hasText('May 3, 2010');
   });
@@ -57,7 +57,7 @@ module('moment', function (hooks) {
 
     this.service.changeLocale('fr');
     await render(
-      hbs`{{moment-format (moment this.date this.inputFormat) this.outputFormat}}`
+      hbs`{{moment-format (moment this.date this.inputFormat) this.outputFormat}}`,
     );
 
     assert.dom(this.element).hasText('mai 3, 2010');
@@ -68,7 +68,7 @@ module('moment', function (hooks) {
     assert.expect(1);
 
     this.service.on('localeChanged', function () {
-      assert.equal(moment.locale(), 'es');
+      assert.strictEqual(moment.locale(), 'es');
       done();
     });
 
@@ -98,7 +98,7 @@ module('moment', function (hooks) {
 
     this.service.setLocale('fr');
     await render(
-      hbs`{{moment-format (moment this.date this.inputFormat) this.outputFormat}}`
+      hbs`{{moment-format (moment this.date this.inputFormat) this.outputFormat}}`,
     );
 
     assert.dom(this.element).hasText('mai 3, 2010');
@@ -108,8 +108,8 @@ module('moment', function (hooks) {
     assert.expect(2);
 
     this.service.updateLocale('en', { week: { dow: 3 } });
-    assert.equal(moment().weekday(0).format('dddd'), 'Wednesday');
+    assert.strictEqual(moment().weekday(0).format('dddd'), 'Wednesday');
     this.service.updateLocale('en', { week: { dow: 0 } });
-    assert.equal(moment().weekday(0).format('dddd'), 'Sunday');
+    assert.strictEqual(moment().weekday(0).format('dddd'), 'Sunday');
   });
 });

test-app-3.x/tests/unit/helpers/is-between-test.js

@@ -35,7 +35,7 @@ module('is-between', function (hooks) {
     this.set('context', context);
 
     await render(
-      hbs`{{is-between '2010-10-19' this.context.date precision='year'}}`
+      hbs`{{is-between '2010-10-19' this.context.date precision='year'}}`,
     );
     assert.dom(this.element).hasText('true');
   });
@@ -52,7 +52,7 @@ module('is-between', function (hooks) {
     this.set('context', context);
 
     await render(
-      hbs`{{is-between '2010-10-19' this.context.date precision='year' inclusivity='()'}}`
+      hbs`{{is-between '2010-10-19' this.context.date precision='year' inclusivity='()'}}`,
     );
     assert.dom(this.element).hasText('false');
   });
@@ -68,7 +68,7 @@ module('is-between', function (hooks) {
     assert.expect(1);
 
     await render(
-      hbs`{{is-between '2010-10-20' '2009-12-31' '2012-01-01' precision='year'}}`
+      hbs`{{is-between '2010-10-20' '2009-12-31' '2012-01-01' precision='year'}}`,
     );
     assert.dom(this.element).hasText('true');
   });
@@ -77,7 +77,7 @@ module('is-between', function (hooks) {
     assert.expect(1);
 
     await render(
-      hbs`{{is-between '2016-10-30' '2016-10-30' '2016-12-30' inclusivity='[)'}}`
+      hbs`{{is-between '2016-10-30' '2016-10-30' '2016-12-30' inclusivity='[)'}}`,
     );
     assert.dom(this.element).hasText('true');
   });
@@ -86,7 +86,7 @@ module('is-between', function (hooks) {
     assert.expect(1);
 
     await render(
-      hbs`{{is-between '2016-10-30' '2016-10-30' '2017-12-30' precision='year' inclusivity='[]'}}`
+      hbs`{{is-between '2016-10-30' '2016-10-30' '2017-12-30' precision='year' inclusivity='[]'}}`,
     );
     assert.dom(this.element).hasText('true');
   });

test-app-3.x/tests/unit/helpers/is-same-or-after-test.js

@@ -49,7 +49,7 @@ module('is-same-or-after', function (hooks) {
     assert.expect(1);
 
     await render(
-      hbs`{{is-same-or-after '2010-12-20' '2010-10-19' precision='year'}}`
+      hbs`{{is-same-or-after '2010-12-20' '2010-10-19' precision='year'}}`,
     );
     assert.dom(this.element).hasText('true');
   });

test-app-3.x/tests/unit/helpers/is-same-or-before-test.js

@@ -32,7 +32,7 @@ module('is-same-or-before', function (hooks) {
     assert.expect(1);
 
     await render(
-      hbs`{{is-same-or-before '2010-12-20' '2010-12-19' precision='year'}}`
+      hbs`{{is-same-or-before '2010-12-20' '2010-12-19' precision='year'}}`,
     );
     assert.dom(this.element).hasText('true');
   });

test-app-3.x/tests/unit/helpers/moment-calendar-test.js

@@ -31,7 +31,7 @@ module('moment-calendar', function (hooks) {
     });
 
     await render(
-      hbs`{{moment-calendar this.date this.referenceDate timeZone='America/New_York'}}`
+      hbs`{{moment-calendar this.date this.referenceDate timeZone='America/New_York'}}`,
     );
     assert.dom(this.element).hasText('Yesterday at 9:30 PM');
   });
@@ -54,7 +54,7 @@ module('moment-calendar', function (hooks) {
     });
 
     await render(
-      hbs`{{moment-calendar this.date this.referenceDate this.formats timeZone='America/New_York'}}`
+      hbs`{{moment-calendar this.date this.referenceDate this.formats timeZone='America/New_York'}}`,
     );
     assert.dom().hasText('Yesterday');
   });
@@ -70,7 +70,7 @@ module('moment-calendar', function (hooks) {
     });
 
     await render(
-      hbs`{{moment-calendar this.date this.referenceDate lastDay=this.lastDay timeZone='America/New_York'}}`
+      hbs`{{moment-calendar this.date this.referenceDate lastDay=this.lastDay timeZone='America/New_York'}}`,
     );
     assert.dom(this.element).hasText('Yesterday!');
   });
@@ -89,13 +89,13 @@ module('moment-calendar', function (hooks) {
     });
 
     await render(
-      hbs`{{moment-calendar this.date this.referenceDate this.formats lastDay='[YESTERDAY]' timeZone='America/New_York'}}`
+      hbs`{{moment-calendar this.date this.referenceDate this.formats lastDay='[YESTERDAY]' timeZone='America/New_York'}}`,
     );
 
-    assert.equal(
+    assert.strictEqual(
       Object.keys(this.formats).length,
       2,
-      'formats object shape does not change'
+      'formats object shape does not change',
     );
     assert.dom(this.element).hasText('YESTERDAY');
   });
@@ -110,7 +110,7 @@ module('moment-calendar', function (hooks) {
     });
 
     await render(
-      hbs`{{moment-calendar this.date this.referenceDate locale="es" timeZone='America/New_York'}}`
+      hbs`{{moment-calendar this.date this.referenceDate locale="es" timeZone='America/New_York'}}`,
     );
     assert.dom(this.element).hasText('hoy a las 3:30');
   });
@@ -125,7 +125,7 @@ module('moment-calendar', function (hooks) {
     });
 
     await render(
-      hbs`{{moment-calendar this.date this.referenceDate timeZone='Australia/Sydney'}}`
+      hbs`{{moment-calendar this.date this.referenceDate timeZone='Australia/Sydney'}}`,
     );
 
     assert

test-app-3.x/tests/unit/helpers/moment-diff-test.js

@@ -68,7 +68,7 @@ module('moment-diff', function (hooks) {
     });
 
     await render(
-      hbs`{{moment-diff this.dateA this.dateB precision='year' float=true}}`
+      hbs`{{moment-diff this.dateA this.dateB precision='year' float=true}}`,
     );
     assert.dom().containsText('.5'); // good ol' rounding error
   });

test-app-3.x/tests/unit/helpers/moment-format-test.js

@@ -62,7 +62,7 @@ module('moment-format', function (hooks) {
     });
 
     await render(
-      hbs`{{moment-format this.date this.outputFormat this.inputFormat}}`
+      hbs`{{moment-format this.date this.outputFormat this.inputFormat}}`,
     );
     assert.dom(this.element).hasText('May 3, 2010');
   });
@@ -101,7 +101,7 @@ module('moment-format', function (hooks) {
 
     this.set('date', 0);
     await render(
-      hbs`{{moment-format this.date 'LLLL' timeZone='America/New_York'}}`
+      hbs`{{moment-format this.date 'LLLL' timeZone='America/New_York'}}`,
     );
     assert.dom(this.element).hasText('Wednesday, December 31, 1969 7:00 PM');
   });
@@ -111,7 +111,7 @@ module('moment-format', function (hooks) {
 
     this.set('date', 0);
     await render(
-      hbs`{{moment-format this.date 'LLLL' timeZone='America/Los_Angeles'}}`
+      hbs`{{moment-format this.date 'LLLL' timeZone='America/Los_Angeles'}}`,
     );
     assert.dom(this.element).hasText('Wednesday, December 31, 1969 4:00 PM');
   });

test-app-3.x/tests/unit/helpers/moment-subtract-test.js

@@ -82,7 +82,7 @@ module('moment-subtract', function (hooks) {
       .format('ddd MMM DD YYYY');
 
     await render(
-      hbs`{{moment-subtract '2016-06-01' this.number precision='days'}}`
+      hbs`{{moment-subtract '2016-06-01' this.number precision='days'}}`,
     );
     assert.dom().containsText(expectedString);
   });

test-app-3.x/tests/unit/helpers/unix-test.js

@@ -15,7 +15,7 @@ module('unix', function (hooks) {
     assert.expect(1);
 
     await render(
-      hbs`{{moment-format (unix 946684799) 'YYYYMMDD' timeZone='America/Los_Angeles'}}`
+      hbs`{{moment-format (unix 946684799) 'YYYYMMDD' timeZone='America/Los_Angeles'}}`,
     );
     assert.dom(this.element).hasText('19991231');
   });

test-app-3.x/tests/unit/helpers/utc-test.js

@@ -56,12 +56,12 @@ module('utc', function (hooks) {
     const utcValue = momentService.utc(utcTimeStr, fmtStr);
     this.set('utcValue', utcValue);
     await render(
-      hbs`{{moment-format (utc this.estValue) 'YYYY-MM-DDTHH:mm:ss Z'}}`
+      hbs`{{moment-format (utc this.estValue) 'YYYY-MM-DDTHH:mm:ss Z'}}`,
     );
     assert.dom(this.element).hasText(utcTimeStr);
 
     await render(
-      hbs`{{moment-format (utc this.utcValue) 'YYYY-MM-DDTHH:mm:ss Z'}}`
+      hbs`{{moment-format (utc this.utcValue) 'YYYY-MM-DDTHH:mm:ss Z'}}`,
     );
     assert.dom(this.element).hasText(utcTimeStr);
   });