Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test-app for each ember major version #410

Merged
merged 29 commits into from
Jun 26, 2024

Conversation

mkszepp
Copy link
Contributor

@mkszepp mkszepp commented Jun 26, 2024

Like discussed in DM, we create for each ember version a extra test-app

This helps us to hold support for old ember versions

.gitignore Outdated Show resolved Hide resolved
Copy link
Collaborator

@NullVoxPopuli NullVoxPopuli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good -- I think we could probably have less duplication by symlinking the tests/helpers and tests/integration (etc) folders, but this is a great way to get CI back to green so that future PRs can have confidence!

Thank you!!

@NullVoxPopuli NullVoxPopuli merged commit 2e9e788 into adopted-ember-addons:master Jun 26, 2024
22 checks passed
@github-actions github-actions bot mentioned this pull request Jun 26, 2024
@mkszepp mkszepp deleted the add-test-apps branch June 26, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants