Add percy #1296
Add percy #1296
Conversation
✅ Deploy Preview for ember-paper ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
mansona
force-pushed
the
percy
branch
2 times, most recently
from
4a98fe5
to
33baac5
Compare
|
@matthewhartstonge I would like to get your opinion on this one. I noticed when I added percy that it wasn't a full-screen snapshot. It turns out that a few decisions were made in the past that prevented that. This PR fixes it but it is actually a breaking change 🙈 I'm wondering if you have any thoughts on what we should do here? Here is the percy build with a before and after my last commit: https://percy.io/Ember/web/ember-paper/builds/37201488/changed/2027196211 |
There was a problem hiding this comment.
I've run a test with percy @ #1297
I've simplified it to only lock if in the dummy app on the catalog route to (hopefully) remove the breaking change. Does that satisfy backwards compat?
I saw dialogs remove scrolling, which becomes an issue with the custom dialogs that run off the screen.
| toastDuration = 60000; | ||
| // Toast duration needs to be falsey so that we can take a snapshot with percy | ||
| // TODO we might be able to clean this up later when we remove use of `later()` in the codebase | ||
| toastDuration = false; |
There was a problem hiding this comment.
ah cool! didn't know we could set this 😂
| @@ -6,6 +6,7 @@ import { inject as service } from '@ember/service'; | |||
| import { faker } from '@faker-js/faker'; | |||
| import { tracked } from '@glimmer/tracking'; | |||
| import { buildGridModel } from '../utils/grid-list'; | |||
| import { isTesting } from '@embroider/macros'; | |||
|
Some tests with 'continue-on-error: true' have failed:
|
No description provided.