Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrades + Embroider compatibility #92

Closed
wants to merge 2 commits into from
Closed

Upgrades + Embroider compatibility #92

wants to merge 2 commits into from

Conversation

thoov
Copy link
Contributor

@thoov thoov commented May 28, 2021

This PR includes:

  • ember-cli-upgrade changes
  • changes to addon/index.js such that there are no "dynamic" requires
  • adds @embroider/test-setup to ember-try's scenarios

Currently blocked by: embroider-build/embroider#826

Apart of: ember-cli/ember-cli#9536

@snewcomer
Copy link
Collaborator

snewcomer commented May 28, 2021 •
edited
Loading

@thoov

Should we throw in these changes to this PR as well? (still have to get past this "Required" check that is in the Settings tab that I don't have access to.). I can't see the travis run in the first place...

#93

@snewcomer snewcomer mentioned this pull request May 28, 2021
Closed
@snewcomer
Copy link
Collaborator

I think we can give Github Actions a shot. The travis CI req has been removed!

@snewcomer
Copy link
Collaborator

👋 Any way I can help here?

@josemarluedke
Copy link

I'm also looking forward to this.

@snewcomer snewcomer mentioned this pull request Jun 21, 2021
Merged
@snewcomer snewcomer mentioned this pull request Jun 23, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thoov @snewcomer @josemarluedke