Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix restore method to work with nested keys #160

Merged

Conversation

linainu
Copy link
Contributor

@linainu linainu commented Feb 14, 2022

restore method converted snapshot with nested keys

{
  changes: { name: 'Jim Bob', address: { country: 'North Korea' } },
  errors: {}
}

into changeset with changes like below

[
  { key: 'name', value: 'Jim Bob' },
  { key: 'address', value: { country: 'North Korea' } }
]

fixed it to be:

[
  { key: 'name', value: 'Jim Bob' },
  { key: 'address.country', value: 'North Korea' }
]

@snewcomer snewcomer added bug Something isn't working enhancement New feature or request labels Feb 15, 2022
Copy link
Collaborator

@snewcomer snewcomer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank yoU!

@snewcomer snewcomer merged commit 7b77cfa into adopted-ember-addons:main Feb 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants