Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix rollbackInvalid removing valid changes #176

Merged
merged 1 commit into from
Aug 5, 2022
Merged

fix rollbackInvalid removing valid changes #176

merged 1 commit into from
Aug 5, 2022

Conversation

vstefanovic97
Copy link
Contributor

@vstefanovic97 vstefanovic97 commented Aug 4, 2022 •
edited
Loading

Steps to reproduce

  1. Create nested property on a changeset
  2. Make it fail validation
  3. Set it to a valid value and validate
  4. Call rollbackInvalid()
  5. Observe that the now valid property had been removed from the changesets changes.

I have created this PR with a fix for this, also added a test case that can be reviewed for reproduction (without the fix the test will fail)

@vstefanovic97 vstefanovic97 mentioned this pull request Aug 4, 2022
Closed
@snewcomer snewcomer added the bug Something isn't working label Aug 5, 2022
snewcomer
snewcomer approved these changes Aug 5, 2022
View reviewed changes
Copy link
Collaborator

@snewcomer snewcomer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@snewcomer snewcomer merged commit f3f256f into adopted-ember-addons:main Aug 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snewcomer snewcomer snewcomer approved these changes

Assignees

@vstefanovic97 vstefanovic97

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vstefanovic97 @snewcomer