Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add further data grid coverage testing #1758

Merged
merged 1 commit into from
May 12, 2023
Merged

Conversation

gdams
Copy link
Member

@gdams gdams commented May 11, 2023

Description of change

Pinning the mui data grid at 6.1.0 for now as it's the latest one that works with react testing library. (mui/mui-x#1151)

Also added @steelhead31's profile image as it's been trying to do this for weeks (we normally check them in)

Checklist

  • npm test passes
  • documentation is changed or added (if applicable)
  • permission has been obtained to add new logo (if applicable)
  • contribution guidelines followed here

@netlify
Copy link

netlify bot commented May 11, 2023

Deploy Preview for eclipsefdn-adoptium ready!

Name Link
🔨 Latest commit f18df63
🔍 Latest deploy log https://app.netlify.com/sites/eclipsefdn-adoptium/deploys/645ce11297862c0008acd27d
😎 Deploy Preview https://deploy-preview-1758--eclipsefdn-adoptium.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codecov
Copy link

codecov bot commented May 11, 2023

Codecov Report

Merging #1758 (f18df63) into main (d1509b8) will increase coverage by 0.29%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1758      +/-   ##
==========================================
+ Coverage   97.62%   97.92%   +0.29%     
==========================================
  Files          84       84              
  Lines        6031     6034       +3     
  Branches      481      486       +5     
==========================================
+ Hits         5888     5909      +21     
+ Misses        143      125      -18     
Impacted Files Coverage Δ
src/__fixtures__/hooks.tsx 100.00% <100.00%> (ø)
src/__fixtures__/page.tsx 100.00% <100.00%> (ø)
src/components/ReleaseNotesRender/index.tsx 100.00% <100.00%> (+10.16%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@karianna karianna merged commit ae5b4aa into adoptium:main May 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants