Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix HCRLateAttachWorkload_previewEnabled failure on jdk17 #394

Merged
merged 1 commit into from
Jan 25, 2021
Merged

Fix HCRLateAttachWorkload_previewEnabled failure on jdk17 #394

merged 1 commit into from
Jan 25, 2021

Conversation

LongyuZhang
Copy link
Contributor

@LongyuZhang LongyuZhang commented Jan 19, 2021 •
edited
Loading

@LongyuZhang LongyuZhang mentioned this pull request Jan 19, 2021
Merged
@LongyuZhang
Copy link
Contributor Author

Test Links:

jdk17:
xlinux: 13275 61 zlinux: 13276 mac: 13277 aix: 13278 win: 13279

jdk16:
xlinux: 13270 zlinux: 13271 mac: 13272 aix: 13273 win: 13274

jdk8:
xlinux: 13265 zlinux: 13266 mac: 13267 aix: 13268 win: 13269

@karianna karianna added the bug label Jan 20, 2021
@karianna karianna added this to the January 2021 milestone Jan 20, 2021
@Mesbah-Alam
Copy link
Contributor

Mesbah-Alam commented Jan 23, 2021 •
edited
Loading

Please rebase the development branch and accept the latest changes for #392 before merging this PR, just to be on the safe side.

@LongyuZhang
Fix HCRLateAttachWorkload_previewEnabled failure on jdk17
f35e6d6 
- Change asm to jvm asm
- Set different Opcodes.ASM versions for jdk 8 and 11+

Signed-off-by: Longyu Zhang <longyu.zhang@ibm.com>
@LongyuZhang
Copy link
Contributor Author

Please rebase the development branch and accept the latest changes for #392 before merging this PR, just to be on the safe side.

The Commit has been rebased, and passed tests (Grinder 13437-13439 for jdk 8, 16 and 17). Thanks.

@llxia
Copy link
Contributor

llxia commented Jan 25, 2021

Thanks @LongyuZhang

@llxia llxia merged commit 605a5b3 into adoptium:master Jan 25, 2021
@pshipton pshipton mentioned this pull request Jan 26, 2021
Closed
@llxia llxia mentioned this pull request Jan 26, 2021
Merged
@andrew-m-leonard andrew-m-leonard mentioned this pull request Feb 5, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smlambert smlambert smlambert approved these changes

@llxia llxia llxia approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
January 2021
Development

Successfully merging this pull request may close these issues.
5 participants
@LongyuZhang @Mesbah-Alam @llxia @smlambert @karianna