Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some files may fail to download or download incompletely #4295

Open
Accelerator1996 opened this issue Feb 1, 2023 · 4 comments
Open

Some files may fail to download or download incompletely #4295

Accelerator1996 opened this issue Feb 1, 2023 · 4 comments

Comments

@Accelerator1996
Copy link
Contributor

For the network in mainland China, it may be somewhat unsmooth, and some files will fail to download or download incompletely at this time. I think it is possible to add the resuming option to the curl command.

Such as dacapo.jar, it cost 5h.
image

But finally, it was incomplete.
image

@llxia
Copy link
Contributor

llxia commented Feb 1, 2023

IMO, 5hrs+ to download the 3rd party jar is not acceptable. I am not sure if adding resuming option is a good workaround.

The logic for 3rd party jar needs to be updated so that we can leverage the stage job - test.getDependency. Please see #3921

@Accelerator1996
Copy link
Contributor Author

Accelerator1996 commented Feb 2, 2023

IMO, 5hrs+ to download the 3rd party jar is not acceptable. I am not sure if adding resuming option is a good workaround.

The logic for 3rd party jar needs to be updated so that we can leverage the stage job - test.getDependency. Please see #3921

I once thought about putting it in test.getDependency, but it is only 180+MB. I thought you didn't have this problem. I think your modification can better solve our problem, thank you very much! However, if we set the execution machine overseas, download speed will be faster, it does not take 5 hours. Our jenkins master node is in mainland China, copying from test.getDependency will be very slow at this time, so I think adding resuming option is beneficial for download dependencies in any case, including when the user has not create the project named test.getDenpendency.

@llxia
Copy link
Contributor

llxia commented Feb 2, 2023

test.getDependency should be set up on your local Jenkins, so it should be fast for you.

@Accelerator1996
Copy link
Contributor Author

test.getDependency should be set up on your local Jenkins, so it should be fast for you.

Thank you! We've add it into test.getDependency in our local Jenkins, and it was fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Todo
Development

No branches or pull requests

2 participants