Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clone the required repo only in test build #4810

Closed
llxia opened this issue Oct 13, 2023 · 4 comments
Closed

Clone the required repo only in test build #4810

llxia opened this issue Oct 13, 2023 · 4 comments
Assignees

Comments

@llxia
Copy link
Contributor

llxia commented Oct 13, 2023

The Openj9 repo is only needed for functional testing. For non-functional test builds (i.e., OpenJDK, system, etc), we do not need to clone the openj9 repo.

We can be more efficient by cloneing the required repo only. This will make test build run fast, save more machine time, and reduce unnecessary network activities.

llxia added a commit to llxia/aqa-tests that referenced this issue Oct 13, 2023
resovles: adoptium#4810

Signed-off-by: Lan Xia <Lan_Xia@ca.ibm.com>
smlambert pushed a commit that referenced this issue Oct 16, 2023
resovles: #4810

Signed-off-by: Lan Xia <Lan_Xia@ca.ibm.com>
@Adirala-Krishna
Copy link

Adirala-Krishna commented Oct 17, 2023

@llxia Our VENDOR_TEST_REPO is not getting cloned after this commit and we are facing issues while running svt tests in jenkins.

Job link where tests ran before commit : Grinder_CR/8882/console
Rebuilding same job link without changing anything, Error: cannot find the following tests issue is seen here as repo is not getting cloned : Grinder_CR/8912/console

Error :
No tests found for target: testList
No parallel test lists generated.
Error: cannot find the following tests: mix.3hrs_1, mix.3hrs_2, mix.3hrs_3, mix.3hrs_4 (note: group target such as sanity is not accepted inside testList)
makeGen.mk:45: recipe for target 'autogen' failed

Test seems running fine when ran without this commit : Grinder_CR/8933/console

Can you please check on this. Thank you.

@llxia
Copy link
Contributor Author

llxia commented Oct 17, 2023

@Adirala-Krishna PR #4818 should address the issue

@Adirala-Krishna
Copy link

Issue got resolved, Thank you very much @llxia

@llxia
Copy link
Contributor Author

llxia commented Oct 18, 2023

PRs are delivered.

@llxia llxia closed this as completed Oct 18, 2023
@llxia llxia self-assigned this Oct 18, 2023
llxia added a commit to llxia/aqa-tests that referenced this issue Nov 22, 2023
resovles: adoptium#4810

Signed-off-by: Lan Xia <Lan_Xia@ca.ibm.com>
pshipton pushed a commit that referenced this issue Nov 22, 2023
resovles: #4810

Signed-off-by: Lan Xia <Lan_Xia@ca.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants