-
-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set JTREG concurrency based on cores and memory size #1427
Conversation
Upstream OpenJDK test framework, roughly, sets it to min(NPROCS/2, MEM_IN_GB/2). Set it to a similar value so as to avoid test reliability issues due to memory limits.
Grinder on the big Aarch64 box with this: It's rather conservative but certainly better than a concurrency value of NPROCS. I'll do some more testing on other boxes and may amend it. Hence, the WIP suffix. |
@smlambert Thoughts? |
Thanks @jerboaa - have been meaning to look at what we were currently doing, based on the troubles seen running on the 'big box' / test-packet-armv8-ubuntu-16-04 reported in #1203 and seen in a bunch of the recent release runs (seen more frequently now that there are less aarch64 machines in the pool. Agree its an improvement, will be good to see it run through the other platforms to make sure it doesn't hose anything, thanks for looking at this ! |
Windows x86_64, JDK 8: Linux ppcle, JDK 13: Mac x86_64, JDK 8: |
Another run on the 96 core aarch64 box (on upstream aarch64 JDK 11.0.6+1 EA build): Contrast this to flaky runs earlier on the same JDK: 11.0.6+1 EA. For example: |
This seems to build OK on Windows/Linux/Mac. I'm removing the |
@smlambert More testing of this completed. Make file seems OK. I don't think any of the failures are related to this patch. Mac/Win (no JRE 8 got downloaded, hence failure). Aarch64 linux on the big box now passes (or is significantly better than before in terms of reliability). ppcle 64 bit linux failures for JDK 13 also seem unrelated. I'd appreciate somebody reviewing this! Thanks! |
Thanks, @smlambert! |
Upstream OpenJDK test framework, roughly, sets it to
min(NPROCS/2, MEM_IN_GB/2). Set it to a similar value
so as to avoid test reliability issues due to memory
limits.