Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add MiniMix_5min target #2107

Merged
merged 1 commit into from
Dec 16, 2020
Merged

Add MiniMix_5min target #2107

merged 1 commit into from
Dec 16, 2020

Conversation

Mesbah-Alam
Copy link
Contributor

@Mesbah-Alam Mesbah-Alam commented Dec 10, 2020 •
edited
Loading

  • Adds a target in extended.system to run a time-based system test

Related to #2104

FYI @ShelleyLambert @pshipton

Signed-off-by: Mesbah_Alam@ca.ibm.com Mesbah_Alam@ca.ibm.com

@Mesbah-Alam
Copy link
Contributor Author

Mesbah-Alam commented Dec 10, 2020 •
edited
Loading

Test:
zLinux : InternalGrinder/12632
Windows: InternalGrinder/12633

@Mesbah-Alam
Copy link
Contributor Author

This PR should be delivered together with : adoptium/aqa-systemtest#384

@Mesbah-Alam Mesbah-Alam added this to the December 2020 milestone Dec 10, 2020
@Mesbah-Alam Mesbah-Alam self-assigned this Dec 10, 2020
@Mesbah-Alam Mesbah-Alam requested review from smlambert and llxia and removed request for smlambert December 10, 2020 21:52
@Mesbah-Alam Mesbah-Alam force-pushed the add-5mins-minimix branch 3 times, most recently from 6226fc1 to 7370bbc Compare December 14, 2020 22:23
@Mesbah-Alam
Copy link
Contributor Author

Hi @llxia , adoptium/aqa-systemtest#384 - has been delivered. Can we deliver this PR now too?

@llxia
Copy link
Contributor

llxia commented Dec 16, 2020

Could we update the Grinder links? Thanks

@Mesbah-Alam
Copy link
Contributor Author

Latest changes were tested here: https://ci.adoptopenjdk.net/view/Test_grinder/job/Grinder/5489/

llxia
llxia approved these changes Dec 16, 2020
View reviewed changes
Copy link
Contributor

@llxia llxia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@llxia llxia merged commit 66579c7 into adoptium:master Dec 16, 2020
@Mesbah-Alam Mesbah-Alam deleted the add-5mins-minimix branch May 12, 2021 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@llxia llxia llxia approved these changes

Assignees

@Mesbah-Alam Mesbah-Alam

Labels
enhancement
Projects
None yet
Milestone
December 2020
Development

Successfully merging this pull request may close these issues.
2 participants
@Mesbah-Alam @llxia