-
-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add comment-triggered PR build action #2222
Conversation
I think we should have the default values for the following parameters: We can adjust this later to cover the common use case. |
The event is There is an open issue in github action and hence have some examples of how to do it. Hope it helpful. actions/checkout#331 Regarding the comment-trigger, it might be helpful to separate if it's a PR comment or an issue comment. If it's a PR comment there will be extra steps to get the branch of PR. If it's an issue comment the branch can be set directly by parameters. ( My understand is for now we can first focus on PR comment) |
For job runBuild you may use |
5175cff
to
9128daa
Compare
@llxia These defaults appear to fail to build. See this run: 544298906 |
This issue has been fixed! See commit 9128daa |
This issue has been fixed! |
Fixed! |
I think you have described how this vulnerability has to be handled. Checking the comment and allowing only the set of parameters for run-aqa. If anything else is present, then exit with an error message. |
This issue has been fixed! See commit 7d7489a The fix/remedy to the issue was to store the user input (the comment body) in an environment variable before passing it to the Python script, as is suggested in this GitHub Security Lab article. |
Add workflow `action.yml` that triggers on a PR comment starting with the word `action` then runs AQA tests based on the parameters. Add `action_argparse.py` that parses PR comments to determine the parameters for AQA tests in the `action.yml` workflow. Co-authored-by: Xichen Pan <xichen.pan@gmail.com> Co-authored-by: patkarns <30379111+patkarns@users.noreply.github.com>
Change the program name to 'action' and preprocess sys.argv arguments so the Python script name is no longer a part of the error messages. Remove required arguments and have default values for all arguments as per Lan Xia's (@llxia) suggestion: >>> I think we should have the default values for the following parameters: --sdk_resource = nightly --build_list = openjdk --target = jdk_math --platform = x86-64_linux --jdk_version = 8 --jdk_impl = openj9 We can adjust this later to cover the common use case.
The fix is to store the user input in an environment variable, then use the environment variable to pass arguments to the python script. https://securitylab.github.com/research/github-actions-untrusted-input
Change the default target `jdk_math` to `_jdk_math` for it to build properly. Prefix targets with an underscore if they do not have one.
3e67df0
to
71e8bf9
Compare
I have changed the keyword to "run aqa". Now instead of "action", use "run aqa".
The issue was that the target required an underscore prefix. Therefore I have made the argparse python script add an underscore prefix if one is not present. |
@llxia @sophia-guo - looks like this PR is ready for a final review 👍 |
.github/workflows/runAqaArgParse.py
Outdated
parser.add_argument('--target', default=['_jdk_math'], nargs='+') | ||
parser.add_argument('--platform', default=['x86-64_linux'], nargs='+') | ||
parser.add_argument('--jdk_version', default=['8'], nargs='+') | ||
parser.add_argument('--jdk_impl', default=['openj9'], nargs='+') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be nicer to set jdk_impl and platform as choices, similarly to build_list and sdk_source?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be openj9
and hotspot
as the only two choices?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be openj9 and hotspot as the only two choices? For jdk_impl @smlambert
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes those 2 choices (and should we ever need it, in future, we can add jdk_vendor as an argument, but will not include it for now)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have set platform as 'x86-64_linux ` with extra space by accident and got https://github.com/sophia-guo/openjdk-tests/runs/1919706546?check_suite_focus=true. It would be nice to set platform as choices so the job would fail when do the parseComment instead of runBuild and can't find the runner.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have set platform as 'x86-64_linux ` with extra space by accident and got https://github.com/sophia-guo/openjdk-tests/runs/1919706546?check_suite_focus=true. It would be nice to set platform as choices so the job would fail when do the parseComment instead of runBuild and can't find the runner.
That would be quite a long choices list. The workflow allows github runner platforms, which include various versions of windows, mac, and linux which are constantly updating. Perhaps restrict to only these few?
x86-64_windows [alias for windows-latest]
x86-64_mac [alias for macos-latest]
x86-64_linux [alias for ubuntu-latest]
windows-latest
macos-latest
ubuntu-latest
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
platform
is what jdk supports on. Here is the list https://github.com/AdoptOpenJDK/openjdk-tests/blob/master/buildenv/jenkins/openjdk_tests. windows-latest
or others are supported virtual-environments in github runners. https://github.com/actions/virtual-environments.
That is no all supported platforms are enabled on github runners.
There is a map between them.
For example x86-64_linux
, x86-64_linux_mixed
, x86-64_linux_xl
can map to any one of ubuntu-16.04
, ubuntu-latest or ubuntu-18.04
, ubuntu-16.04
.
So choices would be [x86-64_linux
, x86-64_linux_mixed
, x86-64_linux_xl
, x86-64_mac
, x86-64_mac_mixed
, x86-64_mac_xl
, x86-64_windows
,x86-64_windows_mixed
,x86-64_windows_xl
]. Going forward some of them will be removed or combined so the list would be smaller.
We can leave it as is and update later if the choices helps.
Name is `test_output` instead of `test_output_system` because it depends on user input. Path has changed from `./**/test_output_*/` to `./**/output_*/
This reverts commit 4c532c6. since the checkout is necessary for fetching get.sh
For now, only hotspot and openj9.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Icohedron
* Add add-exports to HCRLateAttachWorkload_previewEnabled (adoptium#2208) - Add add-exports to HCRLateAttachWorkload_previewEnabled Signed-off-by: Longyu Zhang <longyu.zhang@ibm.com> * Convert iteration based STF based load tests to time-based tests (adoptium#2203) Signed-off-by: Mesbah_Alam@ca.ibm.com <Mesbah_Alam@ca.ibm.com> * AUTO: auto exclude test jdk_foreign_native impl=openj9 ver=16+ (adoptium#2219) - related: adoptium#2218 (comment) Signed-off-by: GitHub <noreply@github.com> Co-authored-by: smlambert <smlambert@users.noreply.github.com> * get.sh: stop mandating GNU tar --strip when extracting debug images (adoptium#2184) Signed-off-by: Stewart X Addison <sxa@redhat.com> * Remove references to eclipse-openj9/openj9#11135 (adoptium#2215) eclipse-openj9/openj9#11135 refers to an uber issue, which will be closed soon. So, the references to eclipse-openj9/openj9#11135 have been replaced with stand-alone trackers for the respective issues. Also, a duplicate for SuperMethodTest.java has been removed. Signed-off-by: Babneet Singh <sbabneet@ca.ibm.com> * Exclude ChaCha20/ChaCha20Poly1305ParamTest.java (adoptium#2221) Issue eclipse-openj9/openj9#11689 Signed-off-by: Peter Shipton <Peter_Shipton@ca.ibm.com> * Update OpenJ9 JDK17 exclude list (adoptium#2217) * Apply adoptium#2188 to OpenJ9 JDK17 exclude list Apply adoptium#2188 to OpenJ9 JDK17 exclude list. Signed-off-by: Babneet Singh <sbabneet@ca.ibm.com> * Apply adoptium#2192 to OpenJ9 JDK17 exclude list Apply adoptium#2192 to OpenJ9 JDK17 exclude list. Signed-off-by: Babneet Singh <sbabneet@ca.ibm.com> * Apply adoptium#2215 to OpenJ9 JDK17 exclude list Apply adoptium#2215 to OpenJ9 JDK17 exclude list. Signed-off-by: Babneet Singh <sbabneet@ca.ibm.com> * Fix charsets,i18n,language_tag and locale_matching for 16 and Create new 4 test cases (adoptium#2214) Co-authored-by: Kentaro Kuramochi <aa324442@KentaronoMacBook-Air.local> * Allow users to set lightweight option (adoptium#2216) The benefit of having lightweight checkout is to save space on Jenkins master. However, Jenkins does not support using Repository URL and Branch build parameters with lightweight checkout together (see https://issues.jenkins.io/browse/JENKINS-48431). In this PR, we set LIGHT_WEIGHT_CEHCKOUT to false and use Repository URL and Branch as build parameters by default. If LIGHT_WEIGHT_CEHCKOUT is set to true, set Repository URL and Branch to its explicit value Signed-off-by: lanxia <lan_xia@ca.ibm.com> * Create ParallelStreamsLoadTest (adoptium#2229) Signed-off-by: Simon Rushton <srushton@redhat.com> * Remove _5m from ParallelStreamsLoadTest targets (adoptium#2231) Signed-off-by: Simon Rushton <srushton@redhat.com> * Enable java/lang/reflect/DefaultMethodMembers/FilterNotMostSpecific.java (adoptium#2230) This was forgot after resolving openj9 issue #7623 Signed-off-by: Jason Feng <fengj@ca.ibm.com> * Merge openj9_custom into jdk_custom (adoptium#2232) - Remove openj9_custom to merge it into jdk_custom Signed-off-by: Longyu Zhang <longyu.zhang@ibm.com> * Move JdiTest playlist entry from lambdaLoadTest to otherLoadTest (adoptium#2233) Signed-off-by: Simon Rushton <srushton@redhat.com> * Reinstate ChaCha20Poly1305ParamTest (adoptium#2236) Issue eclipse-openj9/openj9#11689 Signed-off-by: Peter Shipton <Peter_Shipton@ca.ibm.com> * Replace deprecated triggers with new syntax (adoptium#2237) See https://github.com/jenkinsci/job-dsl-plugin/blob/master/docs/Migration.md#migrating-to-177 Signed-off-by: Adam Brousseau <adam.brousseau88@gmail.com> * Update userGuide to include vendor disable feature (adoptium#2239) Signed-off-by: renfeiw <renfeiw@ca.ibm.com> * Use the new format of disable in playlist file (adoptium#2240) Signed-off-by: renfeiw <renfeiw@ca.ibm.com> * Add a custom playlist target to run system tests (adoptium#2234) Signed-off-by: Mesbah_Alam@ca.ibm.com <Mesbah_Alam@ca.ibm.com> * OpenJ9 AArch64: Enable a BigInteger test back again (adoptium#2242) This commit enables the following test, which used to fail with timeouts on AArch64: - java/math/BigInteger/LargeValueExceptions.java (eclipse-openj9/openj9#9082) Signed-off-by: KONNO Kazuhiro <konno@jp.ibm.com> * OpenJ9 AArch64: excluding stream/CountLargeTest (adoptium#2243) The following test is known to timeout with OpenJ9 AArch64. This commit excludes it. - java/util/stream/test/org/openjdk/tests/java/util/stream/CountLargeTest.java eclipse-openj9/openj9#9040 Signed-off-by: KONNO Kazuhiro <konno@jp.ibm.com> * Allow test autogen user to specify parallel params (adoptium#2248) - Param PARALLEL_DEFAULT will be set as default PARALLEL option - Param NUM_MACHINES will be set if passed Signed-off-by: Adam Brousseau <adam.brousseau88@gmail.com> * Exclude com/sun/crypto AEAD ByteBuffer tests (adoptium#2249) Issue eclipse-openj9/openj9#11390 Signed-off-by: Peter Shipton <Peter_Shipton@ca.ibm.com> * Fix command injection vulnerability in autoTestPR (adoptium#2244) Fixes a command injection vulnerability with the auto test PR GitHub Workflow. See https://securitylab.github.com/research/github-actions-untrusted-input Also removes the unecessary `&& github.event_name != 'pull_request'` condition from the autoTestPR job because it will always be satisfied. (This workflow only triggers upon issue_comment, so `github.event_name` will never be 'pull_request') * Update the userGuide (adoptium#2259) - add a one line to cover the special case of auto disable Signed-off-by: renfeiw <renfeiw@ca.ibm.com> * Add certain directories trigger for PR/push testing (adoptium#2241) * Add certain directories trigger for PR/push testing * use run-aqa with the target specified by the changed dirs * remove unnecessary push trigger, leave only PR trigger * merge openj9 and hotspot, deal with duplication situation * Combine getChangeLocation and getBuildLists into one getBuildLists, remove unnecessary code Co-authored-by: xichen1 <pan.chstu@gmail.com> * Add 1 hour timeouts to all copyArtifacts steps (adoptium#2261) Avoid long hanging builds when copyArtifacts hangs Signed-off-by: Adam Brousseau <adam.brousseau88@gmail.com> * Set Lightweight checkout on child jobs (adoptium#2251) Pass along the LIGHT_WEIGHT_CHECKOUT parameter to the generater in order to have children with the same value. Generally this will be false for Ginders and true eveywhere else Fixes adoptium#2250 Signed-off-by: Adam Brousseau <adam.brousseau88@gmail.com> * Revert "Exclude com/sun/crypto AEAD ByteBuffer tests (adoptium#2249)" (adoptium#2266) This reverts commit 2227228. * AUTO: auto exclude test dacapo-jython impl=openj9 ver=16+ (adoptium#2269) - related: adoptium#2256 (comment) Signed-off-by: GitHub <noreply@github.com> Co-authored-by: smlambert <smlambert@users.noreply.github.com> * Only pass LIGHTWEIGHT to DSL if defined (adoptium#2270) - Currently it will put NULL which will cause toBoolean() to fail Related adoptium#2251 Signed-off-by: Adam Brousseau <adam.brousseau88@gmail.com> * Add jdk_vector for jdk16+ (adoptium#2267) Signed-off-by: lanxia <lan_xia@ca.ibm.com> * AUTO: auto exclude test jdk_foreign_native plat=.*(ppc|arm|390).* (adoptium#2280) - related: adoptium#2265 (comment) Signed-off-by: GitHub <noreply@github.com> Co-authored-by: adamfarley <adamfarley@users.noreply.github.com> * temporarily fix bug of get changed files (adoptium#2277) * Exclude jdk_net related failed tests temporarily (adoptium#2282) - exclude jdk_net failed tests temporarily - for jdk 11, 15, and 16 on related platforms Signed-off-by: Longyu Zhang <longyu.zhang@ibm.com> * add suffix to ignore native tests (adoptium#2283) * add suffix to ignore native tests * remove unnecessary matrix.bulid_list in target list * Remove maketest.sh (adoptium#2285) Signed-off-by: Mesbah_Alam@ca.ibm.com <Mesbah_Alam@ca.ibm.com> * Add comment-triggered PR build action (adoptium#2222) * Add comment-triggered PR build action (adoptium#2199) Add workflow `action.yml` that triggers on a PR comment starting with the word `action` then runs AQA tests based on the parameters. Add `action_argparse.py` that parses PR comments to determine the parameters for AQA tests in the `action.yml` workflow. Co-authored-by: Xichen Pan <xichen.pan@gmail.com> Co-authored-by: patkarns <30379111+patkarns@users.noreply.github.com> * Update indentation for exclusion user guide (adoptium#2288) Signed-off-by: renfeiw <renfeiw@ca.ibm.com> * Fix reportStatus job running on every comment (adoptium#2290) Prevents reportStatus from running on every comment by checking for the same conditions as parseComment: - The comment must begin with `run aqa` keyword - The comment must be a PR comment * Use any node for copying TAP files in parallel test builds (adoptium#2295) Resolve: adoptium#2262 Signed-off-by: lanxia <lan_xia@ca.ibm.com> * Set ulimit for sharedclasscache multithread tests (adoptium#2274) Signed-off-by: Simon Rushton <srushton@redhat.com> * Add test excluded label for auto exclusion (adoptium#2300) Signed-off-by: renfeiw <renfeiw@ca.ibm.com> * Change subset to version (adoptium#2301) Signed-off-by: renfeiw <renfeiw@ca.ibm.com> * Fix GitHub head ref error (adoptium#2308) * test error * test error * remove parentheses * use github.head_ref * remove test file * Update userGuide to change subset to version (adoptium#2307) Signed-off-by: renfeiw <renfeiw@ca.ibm.com> * remove PushOrPRtestbuild.yml (adoptium#2309) * Add alpine-linux and x86-64_solaris platforms (adoptium#2304) * Trial external_custom target Signed-off-by: Shelley Lambert <slambert@gmail.com> * Update build.xml Signed-off-by: Shelley Lambert <slambert@gmail.com> * Add alpine-linux platform label Signed-off-by: Shelley Lambert <slambert@gmail.com> * add bits Signed-off-by: Shelley Lambert <slambert@gmail.com> * Add x86_solaris Signed-off-by: Shelley Lambert <slambert@gmail.com> * Remove waitForANodeToBecomeActive post-parallel (adoptium#2312) This step is unnecessary now that we run on any node. Also remove function as it was only used for this step. Follow up to adoptium#2295 Signed-off-by: Adam Brousseau <adam.brousseau88@gmail.com> * Remove ParallelStreamsLoadTest_special_J9 long running modes 113, 614 (adoptium#2315) Modes 113 and 614 take too long to run across all platforms, and contribute to special.system timeout problems on Windows. (5) 113: -Xgcpolicy:gencon -Xjit:count=0,optlevel=warm,gcOnResolve,rtResolve -Xmn512k -Xnocompressedrefs aix 8: 23min, 11: 31min osx 8: 10min, 11: 20min plinux 8: 18min, 11: 23min xlinux 8: 25min, 11: 40min zlinux 8: 12min, 11: 14min Windows 11: 30min (20) 614: -Xcompressedrefs -Xgcpolicy:gencon -Xjit:counts="- - - - - - 1 1 1 1000 250 250 - - - 10000 100000 10000",gcOnResolve,rtResolve,sampleInterval=2,scorchingSampleThreshold=10000,quickProfile -Xmn512k -Xcheck:gc:vmthreads:all:quiet aix 8: 19min, 11: 27min osx 8: 17min, 11: 17min plinux 8: 18min, 11: 22min xlinux 8: 24min, 11: 33min zlinux 8: 10min, 11: 14min Windows 11: 27min Signed-off-by: Peter Shipton <Peter_Shipton@ca.ibm.com> * Change Renaissance 0.9.0 to 0.11.0 in build.xml (adoptium#2314) Fixes adoptium#2298 * Disable ParallelStreamsLoadTest slow OSRG modes on Windows (adoptium#2316) The OSRG modes run slow only on Windows, and contribute to Windows special.system tests timing out. The Mode Mode107-OSRG (24) can timeout the 60min limit and fail. Issue eclipse-openj9/openj9#11904 variation: (24) Mode107-OSRG JVM_OPTIONS: -Xgcpolicy:optthruput -Xdebug -Xrunjdwp:transport=dt_socket,address=8888,server=y,onthrow=no.pkg.foo,launch=echo -Xjit:enableOSR,enableOSROnGuardFailure,count=1,disableAsyncCompilation Windows 11: 67min aix 8: 9min, 11: 4min osx 8: 3min, 11: 5min plinux 8: 2min, 11: 4min xlinux 8: 4min, 11: 10min zlinux 8: 4min, 11: 6min variation: (25) Mode110-OSRG JVM_OPTIONS: -Xjit:enableOSR,enableOSROnGuardFailure,count=1,disableAsyncCompilation -Xgcpolicy:gencon Windows 11: 32min aix 8: 4min, 11: 5min osx 8: 3min, 11: 2min plinux 8: 4min, 11: 5min xlinux 8: 4min, 11: 6min zlinux 8: 1min, 11: 2min variation: (26) Mode610-OSRG JVM_OPTIONS: -Xcompressedrefs -Xjit:enableOSR,enableOSROnGuardFailure,count=1,disableAsyncCompilation -Xgcpolicy:gencon Windows 11: 25min aix 8: 4min, 11: 5min osx 8: 3min, 11: 2min plinux 8: 3min, 11: 4min xlinux 8: 5min, 11: 6min zlinux 8: 2min, 11: 2min variation: (27) Mode612-OSRG JVM_OPTIONS: -Xcompressedrefs -Xgcpolicy:gencon -Xjit:enableOSR,enableOSROnGuardFailure,count=1,disableAsyncCompilation Windows 11: 33min aix 8: 4min, 11: 5min osx 8: 2min, 11: 4min plinux 8: 3min, 11: 5min xlinux 8: 4min, 11: 6min zlinux 8: 1min, 11: 2min Signed-off-by: Peter Shipton <Peter_Shipton@ca.ibm.com> * AUTO: auto exclude test renaissance-dec-tree ver=16+ (adoptium#2319) - related: adoptium#2255 (comment) Signed-off-by: GitHub <noreply@github.com> Co-authored-by: smlambert <smlambert@users.noreply.github.com> * Disable ParallelStreamsLoadTest slow OSRG modes on Windows (adoptium#2325) Fixes adoptium#2316 (comment) The OSRG modes run slow only on Windows, and contribute to Windows special.system tests timing out. The Mode Mode107-OSRG (24) can timeout the 60min limit and fail. Issue eclipse-openj9/openj9#11904 variation: (24) Mode107-OSRG JVM_OPTIONS: -Xgcpolicy:optthruput -Xdebug -Xrunjdwp:transport=dt_socket,address=8888,server=y,onthrow=no.pkg.foo,launch=echo -Xjit:enableOSR,enableOSROnGuardFailure,count=1,disableAsyncCompilation Windows 11: 67min aix 8: 9min, 11: 4min osx 8: 3min, 11: 5min plinux 8: 2min, 11: 4min xlinux 8: 4min, 11: 10min zlinux 8: 4min, 11: 6min variation: (25) Mode110-OSRG JVM_OPTIONS: -Xjit:enableOSR,enableOSROnGuardFailure,count=1,disableAsyncCompilation -Xgcpolicy:gencon Windows 11: 32min aix 8: 4min, 11: 5min osx 8: 3min, 11: 2min plinux 8: 4min, 11: 5min xlinux 8: 4min, 11: 6min zlinux 8: 1min, 11: 2min variation: (26) Mode610-OSRG JVM_OPTIONS: -Xcompressedrefs -Xjit:enableOSR,enableOSROnGuardFailure,count=1,disableAsyncCompilation -Xgcpolicy:gencon Windows 11: 25min aix 8: 4min, 11: 5min osx 8: 3min, 11: 2min plinux 8: 3min, 11: 4min xlinux 8: 5min, 11: 6min zlinux 8: 2min, 11: 2min variation: (27) Mode612-OSRG JVM_OPTIONS: -Xcompressedrefs -Xgcpolicy:gencon -Xjit:enableOSR,enableOSROnGuardFailure,count=1,disableAsyncCompilation Windows 11: 33min aix 8: 4min, 11: 5min osx 8: 2min, 11: 4min plinux 8: 3min, 11: 5min xlinux 8: 4min, 11: 6min zlinux 8: 1min, 11: 2min Signed-off-by: Peter Shipton <Peter_Shipton@ca.ibm.com> * Set parallel machine limit to the total number of machines (adoptium#2330) Resolve: eclipse-openj9/openj9#12088 Signed-off-by: lanxia <lan_xia@ca.ibm.com> * Convert subset to version (adoptium#2329) - using version in playlists Signed-off-by: renfeiw <renfeiw@ca.ibm.com> * Handle a git command's request for a username on Windows (adoptium#2287) If we call git ls-remote on Window, when the repo doesn't exist, the command asks for a username and hangs. This change disables the request for a username and provides more useful error messages. It also handles the problem appropriately, so instead of failing the build, it correctly sets the repo location to the non-'u' version. Added some timeout-handling code as well, in case someone's running this on a version of git older than 2.3, which may ignore the env var we're using to suppress the username request. Signed-off-by: Adam Farley <adfarley@redhat.com> * OpenJ9 JDK17 Exclude java/lang/Thread/UncaughtExceptionsTest.java (adoptium#2333) Signed-off-by: Jason Feng <fengj@ca.ibm.com> * Only run foreign native test on x86_64 or aarch64 platforms (adoptium#2334) This test requires CLinker, and the upstream community has no current intention to port it to new platforms. So we need to exclude the test on platforms that aren't x86-64 or aarch64. Signed-off-by: Adam Farley <adfarley@redhat.com> * Enable download testimage for jdk8 (adoptium#2320) Signed-off-by: Sophia Guo <sophia.gwf@gmail.com> * Ignore leading and trailing whitespace in parsing (adoptium#2318) Also simplifies the mapping of comment/command arguments to outputs. * os upate to latest (adoptium#2331) * use sw.os.alpine-linux label instead of sw.os.musl for Alpine (adoptium#2336) Signed-off-by: Stewart X Addison <sxa@redhat.com> Co-authored-by: LongyuZhang <longyu.zhang@ibm.com> Co-authored-by: Mesbah Alam <Mesbah_Alam@ca.ibm.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: smlambert <smlambert@users.noreply.github.com> Co-authored-by: Stewart X Addison <6487691+sxa@users.noreply.github.com> Co-authored-by: Babneet Singh <babsingh@users.noreply.github.com> Co-authored-by: Peter Shipton <Peter_Shipton@ca.ibm.com> Co-authored-by: KKES335 <48511024+KKES335@users.noreply.github.com> Co-authored-by: Kentaro Kuramochi <aa324442@KentaronoMacBook-Air.local> Co-authored-by: Lan Xia <Lan_Xia@ca.ibm.com> Co-authored-by: Simon Rushton <srushton@redhat.com> Co-authored-by: Jason Feng <fengj@ca.ibm.com> Co-authored-by: AdamBrousseau <adam.brousseau88@gmail.com> Co-authored-by: Renfei Wang <renfeiw@ca.ibm.com> Co-authored-by: KONNO Kazuhiro <33821890+knn-k@users.noreply.github.com> Co-authored-by: Deric Cheung <cheung.deric@gmail.com> Co-authored-by: XichenPan <xichen.pan@gmail.com> Co-authored-by: xichen1 <pan.chstu@gmail.com> Co-authored-by: adamfarley <adamfarley@users.noreply.github.com> Co-authored-by: yanshan24 <43100949+yanshan24@users.noreply.github.com> Co-authored-by: Shelley Lambert <smlamber@ca.ibm.com> Co-authored-by: YananW <40300331+xfxcwynlc@users.noreply.github.com> Co-authored-by: Adam Farley <adfarley@redhat.com> Co-authored-by: sophia-guo <sophia.gwf@gmail.com>
* Create createTestList.py * Delete createTestList.py * Sync original repo (#5) * Add add-exports to HCRLateAttachWorkload_previewEnabled (#2208) - Add add-exports to HCRLateAttachWorkload_previewEnabled Signed-off-by: Longyu Zhang <longyu.zhang@ibm.com> * Convert iteration based STF based load tests to time-based tests (#2203) Signed-off-by: Mesbah_Alam@ca.ibm.com <Mesbah_Alam@ca.ibm.com> * AUTO: auto exclude test jdk_foreign_native impl=openj9 ver=16+ (#2219) - related: #2218 (comment) Signed-off-by: GitHub <noreply@github.com> Co-authored-by: smlambert <smlambert@users.noreply.github.com> * get.sh: stop mandating GNU tar --strip when extracting debug images (#2184) Signed-off-by: Stewart X Addison <sxa@redhat.com> * Remove references to eclipse-openj9/openj9#11135 (#2215) eclipse-openj9/openj9#11135 refers to an uber issue, which will be closed soon. So, the references to eclipse-openj9/openj9#11135 have been replaced with stand-alone trackers for the respective issues. Also, a duplicate for SuperMethodTest.java has been removed. Signed-off-by: Babneet Singh <sbabneet@ca.ibm.com> * Exclude ChaCha20/ChaCha20Poly1305ParamTest.java (#2221) Issue eclipse-openj9/openj9#11689 Signed-off-by: Peter Shipton <Peter_Shipton@ca.ibm.com> * Update OpenJ9 JDK17 exclude list (#2217) * Apply #2188 to OpenJ9 JDK17 exclude list Apply #2188 to OpenJ9 JDK17 exclude list. Signed-off-by: Babneet Singh <sbabneet@ca.ibm.com> * Apply #2192 to OpenJ9 JDK17 exclude list Apply #2192 to OpenJ9 JDK17 exclude list. Signed-off-by: Babneet Singh <sbabneet@ca.ibm.com> * Apply #2215 to OpenJ9 JDK17 exclude list Apply #2215 to OpenJ9 JDK17 exclude list. Signed-off-by: Babneet Singh <sbabneet@ca.ibm.com> * Fix charsets,i18n,language_tag and locale_matching for 16 and Create new 4 test cases (#2214) Co-authored-by: Kentaro Kuramochi <aa324442@KentaronoMacBook-Air.local> * Allow users to set lightweight option (#2216) The benefit of having lightweight checkout is to save space on Jenkins master. However, Jenkins does not support using Repository URL and Branch build parameters with lightweight checkout together (see https://issues.jenkins.io/browse/JENKINS-48431). In this PR, we set LIGHT_WEIGHT_CEHCKOUT to false and use Repository URL and Branch as build parameters by default. If LIGHT_WEIGHT_CEHCKOUT is set to true, set Repository URL and Branch to its explicit value Signed-off-by: lanxia <lan_xia@ca.ibm.com> * Create ParallelStreamsLoadTest (#2229) Signed-off-by: Simon Rushton <srushton@redhat.com> * Remove _5m from ParallelStreamsLoadTest targets (#2231) Signed-off-by: Simon Rushton <srushton@redhat.com> * Enable java/lang/reflect/DefaultMethodMembers/FilterNotMostSpecific.java (#2230) This was forgot after resolving openj9 issue #7623 Signed-off-by: Jason Feng <fengj@ca.ibm.com> * Merge openj9_custom into jdk_custom (#2232) - Remove openj9_custom to merge it into jdk_custom Signed-off-by: Longyu Zhang <longyu.zhang@ibm.com> * Move JdiTest playlist entry from lambdaLoadTest to otherLoadTest (#2233) Signed-off-by: Simon Rushton <srushton@redhat.com> * Reinstate ChaCha20Poly1305ParamTest (#2236) Issue eclipse-openj9/openj9#11689 Signed-off-by: Peter Shipton <Peter_Shipton@ca.ibm.com> * Replace deprecated triggers with new syntax (#2237) See https://github.com/jenkinsci/job-dsl-plugin/blob/master/docs/Migration.md#migrating-to-177 Signed-off-by: Adam Brousseau <adam.brousseau88@gmail.com> * Update userGuide to include vendor disable feature (#2239) Signed-off-by: renfeiw <renfeiw@ca.ibm.com> * Use the new format of disable in playlist file (#2240) Signed-off-by: renfeiw <renfeiw@ca.ibm.com> * Add a custom playlist target to run system tests (#2234) Signed-off-by: Mesbah_Alam@ca.ibm.com <Mesbah_Alam@ca.ibm.com> * OpenJ9 AArch64: Enable a BigInteger test back again (#2242) This commit enables the following test, which used to fail with timeouts on AArch64: - java/math/BigInteger/LargeValueExceptions.java (eclipse-openj9/openj9#9082) Signed-off-by: KONNO Kazuhiro <konno@jp.ibm.com> * OpenJ9 AArch64: excluding stream/CountLargeTest (#2243) The following test is known to timeout with OpenJ9 AArch64. This commit excludes it. - java/util/stream/test/org/openjdk/tests/java/util/stream/CountLargeTest.java eclipse-openj9/openj9#9040 Signed-off-by: KONNO Kazuhiro <konno@jp.ibm.com> * Allow test autogen user to specify parallel params (#2248) - Param PARALLEL_DEFAULT will be set as default PARALLEL option - Param NUM_MACHINES will be set if passed Signed-off-by: Adam Brousseau <adam.brousseau88@gmail.com> * Exclude com/sun/crypto AEAD ByteBuffer tests (#2249) Issue eclipse-openj9/openj9#11390 Signed-off-by: Peter Shipton <Peter_Shipton@ca.ibm.com> * Fix command injection vulnerability in autoTestPR (#2244) Fixes a command injection vulnerability with the auto test PR GitHub Workflow. See https://securitylab.github.com/research/github-actions-untrusted-input Also removes the unecessary `&& github.event_name != 'pull_request'` condition from the autoTestPR job because it will always be satisfied. (This workflow only triggers upon issue_comment, so `github.event_name` will never be 'pull_request') * Update the userGuide (#2259) - add a one line to cover the special case of auto disable Signed-off-by: renfeiw <renfeiw@ca.ibm.com> * Add certain directories trigger for PR/push testing (#2241) * Add certain directories trigger for PR/push testing * use run-aqa with the target specified by the changed dirs * remove unnecessary push trigger, leave only PR trigger * merge openj9 and hotspot, deal with duplication situation * Combine getChangeLocation and getBuildLists into one getBuildLists, remove unnecessary code Co-authored-by: xichen1 <pan.chstu@gmail.com> * Add 1 hour timeouts to all copyArtifacts steps (#2261) Avoid long hanging builds when copyArtifacts hangs Signed-off-by: Adam Brousseau <adam.brousseau88@gmail.com> * Set Lightweight checkout on child jobs (#2251) Pass along the LIGHT_WEIGHT_CHECKOUT parameter to the generater in order to have children with the same value. Generally this will be false for Ginders and true eveywhere else Fixes #2250 Signed-off-by: Adam Brousseau <adam.brousseau88@gmail.com> * Revert "Exclude com/sun/crypto AEAD ByteBuffer tests (#2249)" (#2266) This reverts commit 2227228. * AUTO: auto exclude test dacapo-jython impl=openj9 ver=16+ (#2269) - related: #2256 (comment) Signed-off-by: GitHub <noreply@github.com> Co-authored-by: smlambert <smlambert@users.noreply.github.com> * Only pass LIGHTWEIGHT to DSL if defined (#2270) - Currently it will put NULL which will cause toBoolean() to fail Related #2251 Signed-off-by: Adam Brousseau <adam.brousseau88@gmail.com> * Add jdk_vector for jdk16+ (#2267) Signed-off-by: lanxia <lan_xia@ca.ibm.com> * AUTO: auto exclude test jdk_foreign_native plat=.*(ppc|arm|390).* (#2280) - related: #2265 (comment) Signed-off-by: GitHub <noreply@github.com> Co-authored-by: adamfarley <adamfarley@users.noreply.github.com> * temporarily fix bug of get changed files (#2277) * Exclude jdk_net related failed tests temporarily (#2282) - exclude jdk_net failed tests temporarily - for jdk 11, 15, and 16 on related platforms Signed-off-by: Longyu Zhang <longyu.zhang@ibm.com> * add suffix to ignore native tests (#2283) * add suffix to ignore native tests * remove unnecessary matrix.bulid_list in target list * Remove maketest.sh (#2285) Signed-off-by: Mesbah_Alam@ca.ibm.com <Mesbah_Alam@ca.ibm.com> * Add comment-triggered PR build action (#2222) * Add comment-triggered PR build action (#2199) Add workflow `action.yml` that triggers on a PR comment starting with the word `action` then runs AQA tests based on the parameters. Add `action_argparse.py` that parses PR comments to determine the parameters for AQA tests in the `action.yml` workflow. Co-authored-by: Xichen Pan <xichen.pan@gmail.com> Co-authored-by: patkarns <30379111+patkarns@users.noreply.github.com> * Update indentation for exclusion user guide (#2288) Signed-off-by: renfeiw <renfeiw@ca.ibm.com> * Fix reportStatus job running on every comment (#2290) Prevents reportStatus from running on every comment by checking for the same conditions as parseComment: - The comment must begin with `run aqa` keyword - The comment must be a PR comment * Use any node for copying TAP files in parallel test builds (#2295) Resolve: #2262 Signed-off-by: lanxia <lan_xia@ca.ibm.com> * Set ulimit for sharedclasscache multithread tests (#2274) Signed-off-by: Simon Rushton <srushton@redhat.com> * Add test excluded label for auto exclusion (#2300) Signed-off-by: renfeiw <renfeiw@ca.ibm.com> * Change subset to version (#2301) Signed-off-by: renfeiw <renfeiw@ca.ibm.com> * Fix GitHub head ref error (#2308) * test error * test error * remove parentheses * use github.head_ref * remove test file * Update userGuide to change subset to version (#2307) Signed-off-by: renfeiw <renfeiw@ca.ibm.com> * remove PushOrPRtestbuild.yml (#2309) * Add alpine-linux and x86-64_solaris platforms (#2304) * Trial external_custom target Signed-off-by: Shelley Lambert <slambert@gmail.com> * Update build.xml Signed-off-by: Shelley Lambert <slambert@gmail.com> * Add alpine-linux platform label Signed-off-by: Shelley Lambert <slambert@gmail.com> * add bits Signed-off-by: Shelley Lambert <slambert@gmail.com> * Add x86_solaris Signed-off-by: Shelley Lambert <slambert@gmail.com> * Remove waitForANodeToBecomeActive post-parallel (#2312) This step is unnecessary now that we run on any node. Also remove function as it was only used for this step. Follow up to #2295 Signed-off-by: Adam Brousseau <adam.brousseau88@gmail.com> * Remove ParallelStreamsLoadTest_special_J9 long running modes 113, 614 (#2315) Modes 113 and 614 take too long to run across all platforms, and contribute to special.system timeout problems on Windows. (5) 113: -Xgcpolicy:gencon -Xjit:count=0,optlevel=warm,gcOnResolve,rtResolve -Xmn512k -Xnocompressedrefs aix 8: 23min, 11: 31min osx 8: 10min, 11: 20min plinux 8: 18min, 11: 23min xlinux 8: 25min, 11: 40min zlinux 8: 12min, 11: 14min Windows 11: 30min (20) 614: -Xcompressedrefs -Xgcpolicy:gencon -Xjit:counts="- - - - - - 1 1 1 1000 250 250 - - - 10000 100000 10000",gcOnResolve,rtResolve,sampleInterval=2,scorchingSampleThreshold=10000,quickProfile -Xmn512k -Xcheck:gc:vmthreads:all:quiet aix 8: 19min, 11: 27min osx 8: 17min, 11: 17min plinux 8: 18min, 11: 22min xlinux 8: 24min, 11: 33min zlinux 8: 10min, 11: 14min Windows 11: 27min Signed-off-by: Peter Shipton <Peter_Shipton@ca.ibm.com> * Change Renaissance 0.9.0 to 0.11.0 in build.xml (#2314) Fixes #2298 * Disable ParallelStreamsLoadTest slow OSRG modes on Windows (#2316) The OSRG modes run slow only on Windows, and contribute to Windows special.system tests timing out. The Mode Mode107-OSRG (24) can timeout the 60min limit and fail. Issue eclipse-openj9/openj9#11904 variation: (24) Mode107-OSRG JVM_OPTIONS: -Xgcpolicy:optthruput -Xdebug -Xrunjdwp:transport=dt_socket,address=8888,server=y,onthrow=no.pkg.foo,launch=echo -Xjit:enableOSR,enableOSROnGuardFailure,count=1,disableAsyncCompilation Windows 11: 67min aix 8: 9min, 11: 4min osx 8: 3min, 11: 5min plinux 8: 2min, 11: 4min xlinux 8: 4min, 11: 10min zlinux 8: 4min, 11: 6min variation: (25) Mode110-OSRG JVM_OPTIONS: -Xjit:enableOSR,enableOSROnGuardFailure,count=1,disableAsyncCompilation -Xgcpolicy:gencon Windows 11: 32min aix 8: 4min, 11: 5min osx 8: 3min, 11: 2min plinux 8: 4min, 11: 5min xlinux 8: 4min, 11: 6min zlinux 8: 1min, 11: 2min variation: (26) Mode610-OSRG JVM_OPTIONS: -Xcompressedrefs -Xjit:enableOSR,enableOSROnGuardFailure,count=1,disableAsyncCompilation -Xgcpolicy:gencon Windows 11: 25min aix 8: 4min, 11: 5min osx 8: 3min, 11: 2min plinux 8: 3min, 11: 4min xlinux 8: 5min, 11: 6min zlinux 8: 2min, 11: 2min variation: (27) Mode612-OSRG JVM_OPTIONS: -Xcompressedrefs -Xgcpolicy:gencon -Xjit:enableOSR,enableOSROnGuardFailure,count=1,disableAsyncCompilation Windows 11: 33min aix 8: 4min, 11: 5min osx 8: 2min, 11: 4min plinux 8: 3min, 11: 5min xlinux 8: 4min, 11: 6min zlinux 8: 1min, 11: 2min Signed-off-by: Peter Shipton <Peter_Shipton@ca.ibm.com> * AUTO: auto exclude test renaissance-dec-tree ver=16+ (#2319) - related: #2255 (comment) Signed-off-by: GitHub <noreply@github.com> Co-authored-by: smlambert <smlambert@users.noreply.github.com> * Disable ParallelStreamsLoadTest slow OSRG modes on Windows (#2325) Fixes #2316 (comment) The OSRG modes run slow only on Windows, and contribute to Windows special.system tests timing out. The Mode Mode107-OSRG (24) can timeout the 60min limit and fail. Issue eclipse-openj9/openj9#11904 variation: (24) Mode107-OSRG JVM_OPTIONS: -Xgcpolicy:optthruput -Xdebug -Xrunjdwp:transport=dt_socket,address=8888,server=y,onthrow=no.pkg.foo,launch=echo -Xjit:enableOSR,enableOSROnGuardFailure,count=1,disableAsyncCompilation Windows 11: 67min aix 8: 9min, 11: 4min osx 8: 3min, 11: 5min plinux 8: 2min, 11: 4min xlinux 8: 4min, 11: 10min zlinux 8: 4min, 11: 6min variation: (25) Mode110-OSRG JVM_OPTIONS: -Xjit:enableOSR,enableOSROnGuardFailure,count=1,disableAsyncCompilation -Xgcpolicy:gencon Windows 11: 32min aix 8: 4min, 11: 5min osx 8: 3min, 11: 2min plinux 8: 4min, 11: 5min xlinux 8: 4min, 11: 6min zlinux 8: 1min, 11: 2min variation: (26) Mode610-OSRG JVM_OPTIONS: -Xcompressedrefs -Xjit:enableOSR,enableOSROnGuardFailure,count=1,disableAsyncCompilation -Xgcpolicy:gencon Windows 11: 25min aix 8: 4min, 11: 5min osx 8: 3min, 11: 2min plinux 8: 3min, 11: 4min xlinux 8: 5min, 11: 6min zlinux 8: 2min, 11: 2min variation: (27) Mode612-OSRG JVM_OPTIONS: -Xcompressedrefs -Xgcpolicy:gencon -Xjit:enableOSR,enableOSROnGuardFailure,count=1,disableAsyncCompilation Windows 11: 33min aix 8: 4min, 11: 5min osx 8: 2min, 11: 4min plinux 8: 3min, 11: 5min xlinux 8: 4min, 11: 6min zlinux 8: 1min, 11: 2min Signed-off-by: Peter Shipton <Peter_Shipton@ca.ibm.com> * Set parallel machine limit to the total number of machines (#2330) Resolve: eclipse-openj9/openj9#12088 Signed-off-by: lanxia <lan_xia@ca.ibm.com> * Convert subset to version (#2329) - using version in playlists Signed-off-by: renfeiw <renfeiw@ca.ibm.com> * Handle a git command's request for a username on Windows (#2287) If we call git ls-remote on Window, when the repo doesn't exist, the command asks for a username and hangs. This change disables the request for a username and provides more useful error messages. It also handles the problem appropriately, so instead of failing the build, it correctly sets the repo location to the non-'u' version. Added some timeout-handling code as well, in case someone's running this on a version of git older than 2.3, which may ignore the env var we're using to suppress the username request. Signed-off-by: Adam Farley <adfarley@redhat.com> * OpenJ9 JDK17 Exclude java/lang/Thread/UncaughtExceptionsTest.java (#2333) Signed-off-by: Jason Feng <fengj@ca.ibm.com> * Only run foreign native test on x86_64 or aarch64 platforms (#2334) This test requires CLinker, and the upstream community has no current intention to port it to new platforms. So we need to exclude the test on platforms that aren't x86-64 or aarch64. Signed-off-by: Adam Farley <adfarley@redhat.com> * Enable download testimage for jdk8 (#2320) Signed-off-by: Sophia Guo <sophia.gwf@gmail.com> * Ignore leading and trailing whitespace in parsing (#2318) Also simplifies the mapping of comment/command arguments to outputs. * os upate to latest (#2331) * use sw.os.alpine-linux label instead of sw.os.musl for Alpine (#2336) Signed-off-by: Stewart X Addison <sxa@redhat.com> Co-authored-by: LongyuZhang <longyu.zhang@ibm.com> Co-authored-by: Mesbah Alam <Mesbah_Alam@ca.ibm.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: smlambert <smlambert@users.noreply.github.com> Co-authored-by: Stewart X Addison <6487691+sxa@users.noreply.github.com> Co-authored-by: Babneet Singh <babsingh@users.noreply.github.com> Co-authored-by: Peter Shipton <Peter_Shipton@ca.ibm.com> Co-authored-by: KKES335 <48511024+KKES335@users.noreply.github.com> Co-authored-by: Kentaro Kuramochi <aa324442@KentaronoMacBook-Air.local> Co-authored-by: Lan Xia <Lan_Xia@ca.ibm.com> Co-authored-by: Simon Rushton <srushton@redhat.com> Co-authored-by: Jason Feng <fengj@ca.ibm.com> Co-authored-by: AdamBrousseau <adam.brousseau88@gmail.com> Co-authored-by: Renfei Wang <renfeiw@ca.ibm.com> Co-authored-by: KONNO Kazuhiro <33821890+knn-k@users.noreply.github.com> Co-authored-by: Deric Cheung <cheung.deric@gmail.com> Co-authored-by: XichenPan <xichen.pan@gmail.com> Co-authored-by: xichen1 <pan.chstu@gmail.com> Co-authored-by: adamfarley <adamfarley@users.noreply.github.com> Co-authored-by: yanshan24 <43100949+yanshan24@users.noreply.github.com> Co-authored-by: Shelley Lambert <smlamber@ca.ibm.com> Co-authored-by: YananW <40300331+xfxcwynlc@users.noreply.github.com> Co-authored-by: Adam Farley <adfarley@redhat.com> Co-authored-by: sophia-guo <sophia.gwf@gmail.com> * Update testJobTemplate Testing param separator * Update testJobTemplate adding styles to header * Update testJobTemplate Categorized all parameters * Update testJobTemplate updated CSS variables * Update testJobTemplate * Update testJobTemplate * Update testJobTemplate * Update testJobTemplate * Update testJobTemplate * Update testJobTemplate * Update testJobTemplate * Update testJobTemplate * Update testJobTemplate * Update testJobTemplate * Update testJobTemplate Testing parameter separator * Update testJobTemplate added CSS styles to parameter separators * Update testJobTemplate to better reflect mockup * Update testJobTemplate * update testJobTemplate, added subtitle styling * fixed typo * Update testJobTemplate * Update testJobTemplate * Update testJobTemplate * Style parameters in testJobTemplate * Add link to Grinder Wiki * edited styling for Grinder wiki link * edited 'grinder wiki' positioning * Added padding to 'Grinder Wiki' link * Updated JDK_BRANCH parameter order * added spaces back to copyright * Update some parameters' default values * Removed extra tab * Removed Grinder wiki link and separator bg color * removed extra spaces in testJobTemplate * added examples in CUSTOM_TARGET * fixed /n error * changed multiline string declaration * added triple quotations around description * moved CUSTOM_TARGET examples to the right spot Co-authored-by: LongyuZhang <longyu.zhang@ibm.com> Co-authored-by: Mesbah Alam <Mesbah_Alam@ca.ibm.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: smlambert <smlambert@users.noreply.github.com> Co-authored-by: Stewart X Addison <6487691+sxa@users.noreply.github.com> Co-authored-by: Babneet Singh <babsingh@users.noreply.github.com> Co-authored-by: Peter Shipton <Peter_Shipton@ca.ibm.com> Co-authored-by: KKES335 <48511024+KKES335@users.noreply.github.com> Co-authored-by: Kentaro Kuramochi <aa324442@KentaronoMacBook-Air.local> Co-authored-by: Lan Xia <Lan_Xia@ca.ibm.com> Co-authored-by: Simon Rushton <srushton@redhat.com> Co-authored-by: Jason Feng <fengj@ca.ibm.com> Co-authored-by: AdamBrousseau <adam.brousseau88@gmail.com> Co-authored-by: Renfei Wang <renfeiw@ca.ibm.com> Co-authored-by: KONNO Kazuhiro <33821890+knn-k@users.noreply.github.com> Co-authored-by: Deric Cheung <cheung.deric@gmail.com> Co-authored-by: XichenPan <xichen.pan@gmail.com> Co-authored-by: xichen1 <pan.chstu@gmail.com> Co-authored-by: adamfarley <adamfarley@users.noreply.github.com> Co-authored-by: yanshan24 <43100949+yanshan24@users.noreply.github.com> Co-authored-by: Shelley Lambert <smlamber@ca.ibm.com> Co-authored-by: YananW <40300331+xfxcwynlc@users.noreply.github.com> Co-authored-by: Adam Farley <adfarley@redhat.com> Co-authored-by: sophia-guo <sophia.gwf@gmail.com>
Implements a GitHub Workflow for triggering PR builds. Addresses #2199
Known issues:
The builds checkout the master branch of the base repo rather than the head repo and branch of the PR. This must be fixed. Would need to change these lines of the workflow file.Fixed!When there is an error in the comment, the resulting error message mentions theFixed!action_argparse.py
script used to parse the comment. A minor issue but I see no obvious fix aside from overriding the error messages of Python'sargparse
or writing a new parser from scratch. (See example error below)A newline at the end of the comment will result in an empty error message. Additionally, one can suffix the comment withFixed!|| <command>
to execute any arbitrary shell command on the GitHub runner. Security issue? I do not see a way to prevent this at the time being.Discussions:
Potential improvements:
custom_target
,openjdk_testRepo
, andtkg_Repo
to pass to the run-aqa action that runs the builds.Example usage:
Example error: