Excluding CheckHandles.java test from 32bit Windows #2388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test was designed for jdk15, and backported as far as jdk11 because jdk8 and 9 were confirmed to not have the issue the test was designed to detect. Since JDK8 was the last openjdk major version supported (by the openjdk project) on windows 32bit, and there appears no indication that this test has ever passed on 32bit windows, I assert that this test was never intended to run on 32bit windows. Since the test currently doesn't *work* on windows 32bit either, for reasons I believe to be related to name mangling, my solution is for us to stop running the test on a platform it's not intended for. Signed-off-by: Adam Farley <adfarley@redhat.com>
smlambert
approved these changes
Mar 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test was designed for jdk15, and backported as far as jdk11
because jdk8 and 9 were confirmed to not have the issue the test
was designed to detect.
Since JDK8 was the last openjdk major version supported (by the
openjdk project) on windows 32bit, and there appears no indication
that this test has ever passed on 32bit windows, I assert that this
test was never intended to run on 32bit windows.
Since the test currently doesn't work on windows 32bit either, for
reasons I believe to be related to name mangling, my solution
is for us to stop running the test on a platform it's not
intended for.
Signed-off-by: Adam Farley adfarley@redhat.com