Update ProblemList_openjdk17.txt with jvm_compiler excludes for windows-x86" #3006
Conversation
|
@King-kay - can you please put a more descriptive title so that its easier to know the contents of the change? Something like: "Update ProblemList_openjdk17.txt with jvm_compiler excludes for windows-x86" |
|
Grinder for testing: https://ci.adoptopenjdk.net/view/Test_grinder/job/Grinder/1707/ |
King-kay
changed the title
|
i've added the exclusion statement for the new tests |
for windows-x86 platform
| compiler/codegen/ClearArrayTest.java windows-x86 | ||
| compiler/c2/TestJumpTable.java windows-x86 | ||
| compiler/loopstripmining/TestPinnedUseInOuterLSMUnusedBySfpt.java windows-x86 | ||
| compiler/vectorapi/TestNoInline.java windows-x86 |
There was a problem hiding this comment.
Please see the format in the other lines of the file,
nameOfClassToExclude URLofIssueFailedTestIsTrackedBy platformsOnWhichToExclude
so your changes on these lines need to also have the issue URL in them
There was a problem hiding this comment.
Added the URL
did I do it properly this time?
There was a problem hiding this comment.
yes @King-kay - each line that you have added appears to have a className anIssueURL and a platform (3 things per line), which is the proper and expected format for these files, thanks!
|
@King-kay Could you do the rebase as suggested by @smlambert #3006 (review) ? Thanks. |
|
I already did @sophia-guo |
|
@King-kay there may be other changes merged. Looks like there are still conflicts. |
| #runtime_nestmate | ||
| runtime/Nestmates/protectionDomain/TestDifferentProtectionDomains.java https://bugs.openjdk.java.net/browse/JDK-8269135 windows-x86 | ||
|
|
||
| >>>>>>> master |
There was a problem hiding this comment.
This line must come from some conflicts. If you could remove it that will be perfect. Thanks.
There was a problem hiding this comment.
Yes, i took it out, does it look okay now?
| @@ -332,6 +332,32 @@ jdk/incubator/vector/Short64VectorTests.java https://github.com/adoptium/aqa-tes | |||
| jdk/incubator/vector/ShortMaxVectorTests.java https://github.com/adoptium/aqa-tests/issues/2874 linux-arm | |||
| ############################################################################ | |||
|
|
|||
| #runtime_nestmate | |||
| runtime/Nestmates/protectionDomain/TestDifferentProtectionDomains.java https://bugs.openjdk.java.net/browse/JDK-8269135 windows-x86 | |||
There was a problem hiding this comment.
should this exclude line be removed? thought this PR was just to add the jvm_compiler excludes
There was a problem hiding this comment.
I thought you asked it to be removed, as it was from a later pr
There was a problem hiding this comment.
ah, okay. Hard to keep things straight with this many PRs. :)
Fix #3004
"Update ProblemList_openjdk17.txt with jvm_compiler excludes for windows-x86"