Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabling java_net tests on all releases except jck11 z/OS #3702

Merged
merged 2 commits into from
Jul 21, 2022

Conversation

psoujany
Copy link
Contributor

This PR enables java_net tests on all releases like 8,11,17 except z/OS.

Fixes : runtimes/backlog/issues/462

Signed off by : Pasam Soujanya psoujany@in.ibm.com

@psoujany
Copy link
Contributor Author

This PR has dependency on JCK internal repos.
JCK8 : runtimes/JCK8-unzipped/pull/32
JCK11 : runtimes/JCK11-unzipped/pull/32
JCK17 : runtimes/JCK17-unzipped/pull/26

Copy link
Contributor

@smlambert smlambert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not an appropriate way or location to make this change, as it is changing configuration files used by the Temurin-compliance project. Suggest that @psoujany @Mesbah-Alam have a private conversation, and pull me in should you need to, to talk about the alternative approach to accomplishing this.

@Mesbah-Alam
Copy link
Contributor

This PR needs to be refreshed by removing all updates except for the playlist xml un-excludes. The rest is being handled by #3704. Please see backlog/issues/799 for more details.

@psoujany
Copy link
Contributor Author

psoujany commented Jun 1, 2022

@Mesbah-Alam Made changes as per above comments. Could you please review the changes. Thank you.

@Mesbah-Alam
Copy link
Contributor

Thanks @psoujany . We should hold off on this PR until #3704 is delivered.

@Mesbah-Alam
Copy link
Contributor

Hi @psoujany - #3704 has been delivered. Could you please accept the latest in your branch (psoujany:enable-jck-java-net) and start a fresh grinder? Thanks!

@psoujany
Copy link
Contributor Author

psoujany commented Jun 6, 2022

Hi @Mesbah-Alam, if I accept new changes to this branch, will there be merge issues later like changes in master will already be in this branch kind issues.

@Mesbah-Alam
Copy link
Contributor

Hi @Mesbah-Alam, if I accept new changes to this branch, will there be merge issues later like changes in master will already be in this branch kind issues.

There should not be any merge conflicts as your change is only in the playlist. Also, this PR can't be tested without accepting the latest anyway. So please accept latest and run the java_net target in a grinder off of your branch.

Copy link
Contributor

@Mesbah-Alam Mesbah-Alam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Mesbah-Alam Mesbah-Alam merged commit 9612499 into adoptium:master Jul 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants