Add portable criu test for ubuntu and ubi #3909
Conversation
LongyuZhang
commented
Aug 3, 2022
•
LongyuZhang
commented
- Add portable criu test with keep checkpoint and restore functions
- Add images for both ubuntu and ubi
- These tests will only run when jdk supports criu
- Related Issue: Docker based CRIU testing eclipse-openj9/openj9#14486 Criu installation for ubi criu portable test #3916
|
@llxia @sophia-guo Could you review it? Thanks. |
|
Test Links:
|
buildenv/jenkins/JenkinsfileBase
Outdated
| // USERNAME and PASSWORD reference with a withCredentials block will not be visible within job output | ||
| withCredentials([usernamePassword(credentialsId: "${env.DOCKER_REGISTRY_URL_CREDENTIAL_ID}", usernameVariable: 'USERNAME', passwordVariable: 'PASSWORD')]) { | ||
| echo "Private Docker Registry login starts:" | ||
| sh 'echo $PASSWORD | docker login --username=$USERNAME --password-stdin ' + "$env.DOCKER_REGISTRY_URL" |
There was a problem hiding this comment.
docker login should not be done in JenkinsfileBase. I think it should be done only when needed (at the test level).
There was a problem hiding this comment.
Docker login has been moved to tests where login is needed (push new image and pull image). New grinder is hyc 26514 and 26515. Thanks.
|
@LongyuZhang I will need to have a desktop review about this PR. I have several questions about this.
|
- Add portable criu test with keep checkpoint and restore functions - Add images for both ubuntu and ubi - These tests will only run when jdk supports criu
|
@llxia The two criu binaries have been removed from the commit. They will be downloaded in dockerfile when building the ubi docker image. Test links: hyc_grinder 26609 and 26610. Thanks. |
|
I will approve this PR. Other improvements (i.e., use |
