Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add aot-portable test #3923

Merged
merged 1 commit into from
Aug 23, 2022
Merged

Add aot-portable test #3923

merged 1 commit into from
Aug 23, 2022

Conversation

LongyuZhang
Copy link
Contributor

Signed-off-by: Longyu Zhang longyu.zhang@ibm.com

@LongyuZhang LongyuZhang marked this pull request as draft August 18, 2022 01:32
@llxia
Copy link
Contributor

llxia commented Aug 18, 2022

Please ensure this PR contains only aot change. Thanks

@LongyuZhang
Copy link
Contributor Author

The criu related tests are modified to add additional --docker_registry_required "true" in this PR, since previous load function in external.sh only pulls image after log into private docker registry, which is not needed for aot-portable test (pull from dockerhub directly).

Test Links:

  • aot_portable-test captures the error AOT header validation failed: Processor incompatible (semeru docker has not been updated link): hyc 26820
  • CRIU ubu_checkpoint (hyc 26824) ubu_restore (hyc 26829) ubi_checkpoint (hyc 26825) ubi_restore (hyc 26828)

@LongyuZhang LongyuZhang marked this pull request as ready for review August 19, 2022 04:30
@llxia
Copy link
Contributor

llxia commented Aug 19, 2022

If we use run (instead of load), will the logic be simpler?
Also, I would prefer to name the folder aot, not aot-portable.

- Add aot docker test

Signed-off-by: Longyu Zhang <longyu.zhang@ibm.com>
@llxia
Copy link
Contributor

llxia commented Aug 19, 2022

Talked with Longyu, and we decided to use load for this PR. As we are supporting more use cases (i.e., testing JDK, testing docker image, creating docker image, etc), we will have a design discussion for external testing workflow in general.

@LongyuZhang
Copy link
Contributor Author

New Test Links (hyc_grinder):

  • aot test: 26841 (captured AOT header validation failed since semeru docker image hasn't updated, link)
  • ubu checkpoint: 26839
  • ubu restore: 26845
  • ubi checkpoint: 26842
  • ubi restore: 26843

Copy link
Contributor

@llxia llxia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@renfeiw renfeiw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@renfeiw renfeiw merged commit bfced13 into adoptium:master Aug 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

3 participants