Ignore exclude lists for jck_custom #3927
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test with jck_custom: Grinder_JCK/571 |
|
Test with FIPS: Grinder_FIPS/120 |
Mesbah-Alam
force-pushed
the
allow-only-standard-excludes-for-jck-custom
branch
6 times, most recently
from
e9bf133
to
84bb351
Compare
Signed-off-by: Mesbah-Alam <Mesbah_Alam@ca.ibm.com>
Mesbah-Alam
force-pushed
the
allow-only-standard-excludes-for-jck-custom
branch
from
84bb351
to
fec19bf
Compare
|
Upon conversation with @llxia , updated the PR to not exclude the jtx and kfl files from exclude dir while using Test:
|
|
There is no FIPS jtx for JDK8. Retest this PR on JDK11: |
smlambert
approved these changes
Aug 24, 2022
There was a problem hiding this comment.
Litmus test in https://ci.eclipse.org/temurin-compliance/job/Grinder/1718/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes sure that when jck_custom target is used, we'd ignore all exclude files except the default.
Signed-off-by: Mesbah-Alam Mesbah_Alam@ca.ibm.com