Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix MBCS_Tests_CLDR_11 CurrencyTest and TimeZoneTestB with JDK 11.0.17+6 #4011

Merged
merged 1 commit into from
Oct 7, 2022
Merged

Fix MBCS_Tests_CLDR_11 CurrencyTest and TimeZoneTestB with JDK 11.0.17+6 #4011

merged 1 commit into from
Oct 7, 2022

Conversation

takiguc
Copy link
Contributor

@takiguc takiguc commented Oct 5, 2022

Fixes #3996

Signed-off-by: Ichiroh Takiguchi takiguc@jp.ibm.com

@takiguc
Copy link
Contributor Author

takiguc commented Oct 5, 2022

This fix has follow changes

  • Fix CLDR11-*.properties test data files for CurrencyTest and TimeZoneTestB
  • Fix gen-patch-data.sh test data generator. It did not work if diff output files had "\uXXXX" string.

Test result is as follows:
Linux x64, JDK11
371 tests, 83 ok, 0 not ok, 288 skipped, 0 ToDo, 0 Bail Out!
https://ci.adoptopenjdk.net/view/Test_grinder/job/Grinder_Simple/340/
PLATFORM: x86-64_linux
BUILD_LIST: functional/MBCS_Tests
TARGET: special.functional
SDK_RESOURCE: nightly
JDK_VERSION: 11
JDK_IMPL: hotspot
LABEL: test-ibmcloud-rhel7-x64-1

CLDR_11 is just for JDK11 only.

@takiguc takiguc changed the title Fix MBCS_Tests_CLDR_11 TimeZoneTestB with JDK 11.0.17+6 Fix MBCS_Tests_CLDR_11 CurrencyTest and TimeZoneTestB with JDK 11.0.17+6 Oct 5, 2022
@takiguc
Copy link
Contributor Author

takiguc commented Oct 5, 2022

I merged 2 patches because git's last comment was not valid.

Test result is as follows:
Linux x64, JDK11
371 tests, 83 ok, 0 not ok, 288 skipped, 0 ToDo, 0 Bail Out!
https://ci.adoptopenjdk.net/view/Test_grinder/job/Grinder_Simple/341/
PLATFORM: x86-64_linux
BUILD_LIST: functional/MBCS_Tests
TARGET: special.functional
SDK_RESOURCE: nightly
JDK_VERSION: 11
JDK_IMPL: hotspot
LABEL: test-ibmcloud-rhel7-x64-1

smlambert
smlambert approved these changes Oct 6, 2022
View reviewed changes
Copy link
Contributor

@smlambert smlambert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you @takiguc !

@sophia-guo sophia-guo merged commit 4f46ed6 into adoptium:master Oct 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sophia-guo sophia-guo sophia-guo approved these changes

@smlambert smlambert smlambert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MBCS_Tests_CLDR_11 was failed by 11.0.17-beta+6
3 participants
@takiguc @smlambert @sophia-guo