Updating mermaid live code #4029
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smlambert
reviewed
Oct 12, 2022
There was a problem hiding this comment.
The first mermaid code block does not render correctly when I view the file in this branch (https://github.com/adoptium/aqa-tests/blob/2a26aa622cc18abae21285497268b202c0a59ed0/README.md), it shows this error:
So something needs to be updated in that block.
The 2 other ones do render correctly.
The 3 .svg files can be deleted entirely, they still show up in this PR as changed, but not deleted at the moment.
|
Hmm, I would check it out and make changes @smlambert |
|
Hi, @smlambert I have updated the block and deleted the SVG files, please review. |
sophia-guo
approved these changes
Oct 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3360
Hello, @smlambert I have migrated the SVG diagrams to use live mermaid 'code' instead of the static captured images of the diagrams that were in the docs/diagrams folder. Please kindly review and merge. Thank you.