Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update logic for Parallel option with num_machines=1 #4102

Merged
merged 1 commit into from
Nov 2, 2022

Conversation

llxia
Copy link
Contributor

@llxia llxia commented Oct 31, 2022

When running tests with Parallel option and num_machines=1, run tests serially.
Don't do parallel as it will create unnecessary overhead

resolve: #4093
Signed-off-by: Lan Xia Lan_Xia@ca.ibm.com

When running tests with Parallel option and num_machines=1, run tests serially.
Don't do parallel as it will create unnecessary overhead

resolve: adoptium#4093
Signed-off-by: Lan Xia <Lan_Xia@ca.ibm.com>
@llxia
Copy link
Contributor Author

llxia commented Nov 1, 2022

@llxia llxia marked this pull request as ready for review November 1, 2022 15:33
Copy link
Contributor

@LongyuZhang LongyuZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@smlambert smlambert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @llxia !

@smlambert smlambert merged commit d35e9d1 into adoptium:master Nov 2, 2022
@AdamBrousseau
Copy link
Contributor

Is NUM_MACHINES calculated or taken only from the param?
Thinking of the case where parallelx4 is requested but only 1 machine satisfies the label(s). Will we end up launching 1 child job or will this change catch that case?

@llxia
Copy link
Contributor Author

llxia commented Nov 2, 2022

Is NUM_MACHINES calculated or taken only from the param?
Thinking of the case where parallelx4 is requested but only 1 machine satisfies the label(s). Will we end up launching 1 child job or will this change catch that case?

We take NUM_MACHINES from the param and we will do check. It cannot be more than the number of available machines. In the above case, we end up launching 1 child job.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Jenkins: Parallel option should be ignored when num machines is 1
4 participants