Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check jtr file only if previous cmd completed successfully #4117

Merged
merged 1 commit into from
Nov 4, 2022
Merged

Check jtr file only if previous cmd completed successfully #4117

merged 1 commit into from
Nov 4, 2022

Conversation

llxia
Copy link
Contributor

@llxia llxia commented Nov 4, 2022

fix: #4115
Signed-off-by: Lan Xia Lan_Xia@ca.ibm.com

@llxia
Check jtr file only if previous cmd completed successfully
9e11c32 
fix: adoptium#4115
Signed-off-by: Lan Xia <Lan_Xia@ca.ibm.com>
@llxia
Copy link
Contributor Author

llxia commented Nov 4, 2022 •
edited
Loading

@llxia
Copy link
Contributor Author

llxia commented Nov 4, 2022

FYI @pshipton

@llxia llxia marked this pull request as ready for review November 4, 2022 16:56
renfeiw
renfeiw approved these changes Nov 4, 2022
View reviewed changes
Copy link
Contributor

@renfeiw renfeiw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

LongyuZhang
LongyuZhang approved these changes Nov 4, 2022
View reviewed changes
Copy link
Contributor

@LongyuZhang LongyuZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

LongyuZhang
LongyuZhang approved these changes Nov 4, 2022
View reviewed changes
Copy link
Contributor

@LongyuZhang LongyuZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LongyuZhang LongyuZhang merged commit bd84ed3 into adoptium:master Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LongyuZhang LongyuZhang LongyuZhang approved these changes

@renfeiw renfeiw renfeiw approved these changes

@smlambert smlambert Awaiting requested review from smlambert

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Failures occurred, TAP results and TEST TARGETS SUMMARY don't report failures
3 participants
@llxia @renfeiw @LongyuZhang