Add check for testFlag to be nonempty before using testFlag jtx + Add README for tck exclude list types #4170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sanity check: Grinder/29814. |
Mesbah-Alam
force-pushed
the
fix-backlog-974
branch
6 times, most recently
from
323344a
to
af8e3c8
Compare
Mesbah-Alam
changed the title
smlambert
reviewed
Nov 28, 2022
jck/README.md
Outdated
| @@ -101,3 +101,15 @@ cd TKG | |||
| make compile | |||
| make _sanity.jck | |||
| ``` | |||
|
|
|||
| ## TCK exlude lists | |||
There was a problem hiding this comment.
Suggested change
| ## TCK exlude lists | |
| ## TCK exclude lists |
jck/README.md
Outdated
|
|
||
| 3. Standard excludes: These are the 3 standard exclude files (jtx and kfl) that come with tck materials. These constitute known failures and are not updated by vendors. | ||
|
|
||
| Note In regular automated runs in Jenkins, we will only see the exclude list of type 1 and 3. In grinder runs where `jck_custom` is used, Dev exclude is ignored. |
There was a problem hiding this comment.
Suggested change
| Note In regular automated runs in Jenkins, we will only see the exclude list of type 1 and 3. In grinder runs where `jck_custom` is used, Dev exclude is ignored. | |
| Note In regular automated runs in Jenkins, we will only see the exclude list of type 1 and 3. In grinder runs where `jck_custom` is used, Dev exclude is ignored. Type 1 and 2 are used during development not for certification use. |
jck/README.md
Outdated
|
|
||
| We have three types of tck exclude lists: | ||
|
|
||
| 1. Dev excludes: This exclude file, ending with `-dev` (e.g. jck8c-dev.jtx), contains vendor specific excludes. All excludes related to automation run by a specific vendor would go into the `*dev.jtx` files in tck repositories maintained by that vendor. |
There was a problem hiding this comment.
Suggested change
| 1. Dev excludes: This exclude file, ending with `-dev` (e.g. jck8c-dev.jtx), contains vendor specific excludes. All excludes related to automation run by a specific vendor would go into the `*dev.jtx` files in tck repositories maintained by that vendor. | |
| 1. Dev excludes: This exclude file, ending with `-dev` (e.g. jck8c-dev.jtx), contains vendor specific excludes. All excludes related to automation run by a specific vendor would go into the `*dev.jtx` files in tck repositories maintained by that vendor for use during development not certification. |
jck/README.md
Outdated
|
|
||
| 1. Dev excludes: This exclude file, ending with `-dev` (e.g. jck8c-dev.jtx), contains vendor specific excludes. All excludes related to automation run by a specific vendor would go into the `*dev.jtx` files in tck repositories maintained by that vendor. | ||
|
|
||
| 2. Test-flag specific excludes: These exclude files allow developers to add feature specific temporary excludes. For example, the FIPS specific exclude file (e.g., jck8c-fips.jtx) contains list of excludes specific to FIPS that will only be in effect if `TEST_FLAG` is set to `fips`. |
There was a problem hiding this comment.
Suggested change
| 2. Test-flag specific excludes: These exclude files allow developers to add feature specific temporary excludes. For example, the FIPS specific exclude file (e.g., jck8c-fips.jtx) contains list of excludes specific to FIPS that will only be in effect if `TEST_FLAG` is set to `fips`. | |
| 2. Test-flag specific excludes: These exclude files support development work by allowing developers to add feature specific temporary excludes. For example, the FIPS specific exclude file (e.g., jck8c-fips.jtx) contains list of excludes specific to FIPS that will only be in effect if `TEST_FLAG` is set to `fips`. These files are not used for development not for certification. |
Signed-off-by: Mesbah Alam <Mesbah_Alam@ca.ibm.com>
Mesbah-Alam
force-pushed
the
fix-backlog-974
branch
from
af8e3c8
to
d692d1b
Compare
|
Thanks for your review comments @ShelleyLambert ! I've made all the updates suggested above. |
smlambert
approved these changes
Nov 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Mesbah Alam Mesbah_Alam@ca.ibm.com