Re-enable JTReg test thrinfo01 #4174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Related: eclipse-openj9/openj9#16226 |
llxia
approved these changes
Nov 30, 2022
dipak-bagadiya
commented
Nov 30, 2022
|
please update the commit message to something like Please also update the title of this PR. Convension is that the reference to openj9 PR should be part of the message, not title. |
dipak-bagadiya
changed the title
|
@fengxue-IS -> I updated the title and comment as needed. |
Mesbah-Alam
approved these changes
Dec 1, 2022
|
@dipak-bagadiya could you also update the commit message? Thanks |
|
Also, it should be past tense: Test has been fixed by eclipse-openj9/openj9#16376. |
Test had been fixed by- eclipse-openj9/openj9#16376 Signed-off-by: Dipak Bagadiya dipak.bagadiya@ibm.com
dipak-bagadiya
force-pushed
the
thread-group-fix
branch
from
b1f461e
to
f4503bc
Compare
|
@fengxue-IS @babsingh @llxia I updated the commit message and made the past tense in the description part. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-enable JTReg test thrinfo01
Test had been fixed by eclipse-openj9/openj9#16376
Signed-off-by: Dipak Bagadiya dipak.bagadiya@ibm.com