Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add configuration for tck-20 + remove unused old versions #4233

Merged
merged 1 commit into from
Jan 12, 2023
Merged

Add configuration for tck-20 + remove unused old versions #4233

merged 1 commit into from
Jan 12, 2023

Conversation

Mesbah-Alam
Copy link
Contributor

@Mesbah-Alam Mesbah-Alam commented Jan 10, 2023 •
edited
Loading

  • Adds configuration for tck-20
  • Removes configuration folders for unused old versions: 9, 10, 12, 13, 14, 15, 16 & 18.
  • Updates jtrunner/makefile to only build jckforeign for 19, as it has been removed in 20.

Signed-off-by: Mesbah Alam Mesbah_Alam@ca.ibm.com

@Mesbah-Alam
Add configuration for tck-20 + remove unused old versions
03050c2 
Signed-off-by: Mesbah Alam <Mesbah_Alam@ca.ibm.com>
@Mesbah-Alam
Copy link
Contributor Author

Test with 20 : Grinder_JCK/1022.
Sanity check with 19: Grinder_JCK/1023.

@Mesbah-Alam Mesbah-Alam marked this pull request as ready for review January 10, 2023 20:52
llxia
llxia approved these changes Jan 12, 2023
View reviewed changes
Copy link
Contributor

@llxia llxia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

smlambert
smlambert approved these changes Jan 12, 2023
View reviewed changes
Copy link
Contributor

@smlambert smlambert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the cleanup @Mesbah-Alam !

@smlambert smlambert merged commit 62e4d43 into adoptium:master Jan 12, 2023
@Mesbah-Alam Mesbah-Alam deleted the add-tck-20-configuration branch February 6, 2023 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@llxia llxia llxia approved these changes

@smlambert smlambert smlambert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Mesbah-Alam @smlambert @llxia