Set up jdk for jck interactive #4239

sophia-guo · 2023-01-13T15:21:02Z

Signed-off-by: Sophia Guo sophia.gwf@gmail.com

smlambert

thanks Sophia, we will continue to test and annotate https://github.com/temurin-compliance/temurin-compliance/issues/151 with results, but from preliminary runs, looks good.

smlambert · 2023-01-13T15:58:03Z

buildenv/jenkins/JenkinsfileBase

@@ -469,6 +516,9 @@ def get_sources() {
 			sh "$GET_SH_CMD"
 		}
 	}
+	if (env.BUILD_LIST.contains('jck') && CUSTOMIZED_SDK_URL != "") {


I know I suggested checking CUSTOMIZED_SDK_URL was populated, but could also use SDK_RESOURCE.contains('customized').

Even better. Updated

llxia · 2023-01-13T16:09:46Z

buildenv/jenkins/JenkinsfileBase

@@ -469,6 +516,9 @@ def get_sources() {
 			sh "$GET_SH_CMD"
 		}
 	}
+	if (env.BUILD_LIST.contains('jck') && CUSTOMIZED_SDK_URL != "") {
+		setup_jck_interactives()
+	}


setup_jck_interactives() is an additional step added for preparing SDK for JCK interactives. Since it has nothing to do with automatic JCK test execution, I think this setup_jck_interactives() should happen after the test execution in the Post stage

aqa-tests/buildenv/jenkins/JenkinsfileBase

Line 720 in f0047a6

stage('Post') {

or create its own stage after Post stage. Mixing the step in get_sources() will cause confusion.

We discussed putting it at the end. Why we decided not to was, if we wait to do this step in the post stage, due to the long running jck tests, it means that the setup might take several hours (in some cases 12+ hrs), which then reduces our ability to make our target release goals (2 days for primaries, 7 days for secondaries).

Noting that for those not using this approach, the call to setup_jck_interactives() does nearly nothing (checks for existence of a directory that is not present and returns).

smlambert · 2023-01-13T19:32:28Z

From our Slack discussion, the request to add a flag, SETUP_JCK_RUN (false by default) to ensure this code does not run for others.

	if (env.BUILD_LIST.contains('jck') && SDK_RESOURCE.contains('customized') && (params.SETUP_JCK_RUN)) {
		setup_jck_interactives()
	}

In terms of setting the flag, for the upcoming release, either we prepare a PR for ci-jenkins-pipeline to adjust the remoteTrigger, or modify aqaTestPipeline.groovy to have that same param, which on Temurin-compliance server could be configured to be true by default.

andrew-m-leonard · 2023-01-13T19:50:44Z

buildenv/jenkins/JenkinsfileBase

+				cd ${jdkDir}
+				cp -r ${TEST_JDK_HOME}/* .
+				chgrp -R jck ${targetDir}/${jdkDir}
+				chmod -R 755 ${targetDir}/${jdkDir}


This needs to be 775 so that jck users can delete the files

sophia-guo · 2023-01-13T20:17:07Z

Tested in Eclipse compliance . Issue https://github.com/temurin-compliance/temurin-compliance/issues/151#issuecomment-1380800009

smlambert

I am fine with the changes as they are, but @llxia would like to see an explicit flag added (see #4239 (comment)) for extra safety. And of course to update to 775 as per Andrew's review.

Signed-off-by: Sophia Guo <sophia.gwf@gmail.com>

sophia-guo · 2023-02-03T22:44:45Z

Updated with extra SETUP_JCK_RUN flag or jenkins parameters. Eclipse temurin job AQA_Test_Pipeline updated

sophia-guo · 2023-02-03T22:45:24Z

TODO: Eclipse temurin tests jobs need to regen.

sophia-guo · 2023-02-03T22:49:01Z

Other enhancement like stage jdk on all machines with same label can be done separately.

llxia

Thanks @sophia-guo

* Set up jdk for jck interactive Signed-off-by: Sophia Guo <sophia.gwf@gmail.com> * Add parameter SETUP_JCK_RUN explicitely Signed-off-by: Sophia Guo <sophia.gwf@gmail.com> --------- Signed-off-by: Sophia Guo <sophia.gwf@gmail.com>

* Set up jdk for jck interactive (#4239) * Set up jdk for jck interactive Signed-off-by: Sophia Guo <sophia.gwf@gmail.com> * Add parameter SETUP_JCK_RUN explicitely Signed-off-by: Sophia Guo <sophia.gwf@gmail.com> --------- Signed-off-by: Sophia Guo <sophia.gwf@gmail.com> * [Jtreg/FFI] Disable FFI related test suite in JDK20 (#4318) The change is to exclude the FFI related test cases in AttachTest.java captured at eclipse-openj9/openj9#16656 given the FFI related code in JDK20 has been disabled for the moment and will be enabled once the code has been updated against the latest APIs. Signed-off-by: ChengJin01 <jincheng@ca.ibm.com> * Fix if condition for tck interactive setup (#4320) Signed-off-by: Mesbah Alam <Mesbah_Alam@ca.ibm.com> * [Jtreg/FFI] update the issue no for FFI test suites in JDK20 (#4324) The change updates the issue no by replacing #16656 with #16565 as #16656 will be closed as duplicate of #16565, in which case #16565 serves as the only issue that keeps track of the excluded FFI test suites in JDK20. Signed-off-by: ChengJin01 <jincheng@ca.ibm.com> * Add OpenJ9 timeout handler to security and rmi extended tests (#4333) Signed-off-by: Peter Shipton <Peter_Shipton@ca.ibm.com> * Disable GetStackTraceSuspendedStressTest (#4360) Related: eclipse-openj9/openj9#16751 Signed-off-by: Babneet Singh <sbabneet@ca.ibm.com> * Update JDK20 exclude list (#4371) Re-enable Thread related tests fixed in JDK19 Signed-off-by: Jack Lu <Jack.S.Lu@ibm.com> * Disable ContinuationTest (#4380) ContinuationTest is being disabled for OpenJ9 since it is specific to the reference implementation and it does not apply to OpenJ9. Signed-off-by: Babneet Singh <sbabneet@ca.ibm.com> * Permanently disable ContinuationTest (#4382) Refer to #1297 to permanently exclude. Related: eclipse-openj9/openj9#16792 Related: #1297 Signed-off-by: Babneet Singh <sbabneet@ca.ibm.com> * Exclude jdk/internal/platform/docker/TestDockerCpuMetrics.java (#4387) Signed-off-by: Jason Feng <fengj@ca.ibm.com> * AUTO: auto exclude test jdk_svc_sanity plat=ppc64_aix impl=hotspot (#4389) - related: #4218 (comment) Signed-off-by: GitHub <noreply@github.com> Co-authored-by: smlambert <smlambert@users.noreply.github.com> --------- Signed-off-by: Sophia Guo <sophia.gwf@gmail.com> Signed-off-by: ChengJin01 <jincheng@ca.ibm.com> Signed-off-by: Mesbah Alam <Mesbah_Alam@ca.ibm.com> Signed-off-by: Peter Shipton <Peter_Shipton@ca.ibm.com> Signed-off-by: Babneet Singh <sbabneet@ca.ibm.com> Signed-off-by: Jack Lu <Jack.S.Lu@ibm.com> Signed-off-by: Jason Feng <fengj@ca.ibm.com> Signed-off-by: GitHub <noreply@github.com> Co-authored-by: Cheng Jin <jincheng@ca.ibm.com> Co-authored-by: Mesbah Alam <Mesbah_Alam@ca.ibm.com> Co-authored-by: Peter Shipton <Peter_Shipton@ca.ibm.com> Co-authored-by: Babneet Singh <babsingh@users.noreply.github.com> Co-authored-by: Jack Lu <Jack.S.Lu@ibm.com> Co-authored-by: Jason Feng <fengj@ca.ibm.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: smlambert <smlambert@users.noreply.github.com>

sophia-guo marked this pull request as draft January 13, 2023 15:21

smlambert requested a review from llxia January 13, 2023 15:56

smlambert reviewed Jan 13, 2023

View reviewed changes

llxia reviewed Jan 13, 2023

View reviewed changes

sophia-guo force-pushed the getHack branch 2 times, most recently from e134851 to 1f4bf86 Compare January 13, 2023 19:12

andrew-m-leonard reviewed Jan 13, 2023

View reviewed changes

sophia-guo force-pushed the getHack branch from 1f4bf86 to 1e1f3ca Compare January 13, 2023 20:13

sophia-guo self-assigned this Jan 13, 2023

sophia-guo marked this pull request as ready for review January 13, 2023 20:15

sophia-guo requested review from llxia, smlambert and andrew-m-leonard January 13, 2023 20:15

smlambert reviewed Jan 13, 2023

View reviewed changes

andrew-m-leonard approved these changes Jan 13, 2023

View reviewed changes

sophia-guo force-pushed the getHack branch from 1feb7fe to df6c35b Compare January 17, 2023 13:57

sophia-guo added 2 commits February 3, 2023 14:09

Set up jdk for jck interactive

2f016a6

Signed-off-by: Sophia Guo <sophia.gwf@gmail.com>

Add parameter SETUP_JCK_RUN explicitely

6252ce6

Signed-off-by: Sophia Guo <sophia.gwf@gmail.com>

sophia-guo force-pushed the getHack branch from df6c35b to 6252ce6 Compare February 3, 2023 21:13

sophia-guo mentioned this pull request Feb 3, 2023

Remote trigger with SETUP_JCK_RUN parameter adoptium/ci-jenkins-pipelines#605

Merged

llxia approved these changes Feb 7, 2023

View reviewed changes

llxia merged commit fbe94bc into adoptium:master Feb 7, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Set up jdk for jck interactive #4239

Set up jdk for jck interactive #4239

sophia-guo commented Jan 13, 2023

smlambert left a comment

smlambert Jan 13, 2023

sophia-guo Jan 13, 2023

llxia Jan 13, 2023

smlambert Jan 13, 2023

smlambert Jan 13, 2023

smlambert commented Jan 13, 2023

andrew-m-leonard Jan 13, 2023

sophia-guo Jan 13, 2023

sophia-guo commented Jan 13, 2023

smlambert left a comment •

edited

Loading

sophia-guo commented Feb 3, 2023

sophia-guo commented Feb 3, 2023

sophia-guo commented Feb 3, 2023

llxia left a comment

Set up jdk for jck interactive #4239

Set up jdk for jck interactive #4239

Conversation

sophia-guo commented Jan 13, 2023

smlambert left a comment

Choose a reason for hiding this comment

smlambert Jan 13, 2023

Choose a reason for hiding this comment

sophia-guo Jan 13, 2023

Choose a reason for hiding this comment

llxia Jan 13, 2023

Choose a reason for hiding this comment

smlambert Jan 13, 2023

Choose a reason for hiding this comment

smlambert Jan 13, 2023

Choose a reason for hiding this comment

smlambert commented Jan 13, 2023

andrew-m-leonard Jan 13, 2023

Choose a reason for hiding this comment

sophia-guo Jan 13, 2023

Choose a reason for hiding this comment

sophia-guo commented Jan 13, 2023

smlambert left a comment • edited Loading

Choose a reason for hiding this comment

sophia-guo commented Feb 3, 2023

sophia-guo commented Feb 3, 2023

sophia-guo commented Feb 3, 2023

llxia left a comment

Choose a reason for hiding this comment

smlambert left a comment •

edited

Loading