-
-
Notifications
You must be signed in to change notification settings - Fork 314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial support for the SPECjbb perf testing benchmark #4363
Initial support for the SPECjbb perf testing benchmark #4363
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if shellcheck was run, but if not then that's worth doing so as well.
* update SpecJBB job from initial TRSS testing * fix bug * fixup * rewrite getSpecjbbSuite.sh using antfile
@smlambert I think this is in a good state now, one initial thought is what would be the best way to skip this when the specJBB material isn’t available? E.g can we skip on Temurin but run elsewhere? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still a few of my comments left to go, but none are blockers so I'm approving
Co-authored-by: George Adams <george.adams@microsoft.com>
Co-authored-by: Shelley Lambert <slambert@gmail.com>
…y test to run as part of AQAvit verification Co-authored-by: Shelley Lambert <slambert@gmail.com>
Co-authored-by: Shelley Lambert <slambert@gmail.com>
6111d45
to
d06909c
Compare
Co-authored-by: Shelley Lambert <slambert@gmail.com>
This PR seems incomplete and it breaks the internal perf test build compilation due to From README of this PR :
This test is assuming Error detail:
|
@Mesbah-Alam this issue was fixed in 3c48ef4, does IBM have this patch internally? |
Hi @gdams , thanks for the info. The failing internal build (launched on March 9th) had missed this fix. Will monitor the next one. |
Initial support for SPECjbb will allow users who already have a licensed local copy of the benchmark to launch a simple run in multi-jvm mode from within aqa-test.
Please see
perf/specjbb/README.md
for instructions on how to use this feature.