Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove suffix #id\d{1} as part of openjdk testcase name #4398

Merged
merged 2 commits into from
Mar 7, 2023

Conversation

sophia-guo
Copy link
Contributor

  • Jtreg doesn't support to specify testcase name suffixed with #id\d{1}
  • the special character in url without encoding will also lead to wrong behaviour

Fix #4385

Signed-off-by: Sophia Guo sophia.gwf@gmail.com

Copy link
Contributor

@karianna karianna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could do with a comment explaining why

@sophia-guo
Copy link
Contributor Author

Jtreg doesn't support to specify testcase name suffixed with #id\d{1}

One way to run openjdk test using JTreg is to specify testcase name, for example: java/lang/String/StringRepeat.java. When specify as java/lang/String/StringRepeat.java#id1 it won't work.

Copy link
Contributor

@llxia llxia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

-Jtreg doesn't support to specify testcase name suffixed with #id\d{1}
-the special character in url without encoding will also lead to wrong
behavior

Signed-off-by: Sophia Guo <sophia.gwf@gmail.com>
buildenv/jenkins/JenkinsfileBase Outdated Show resolved Hide resolved
@karianna karianna merged commit e2b3a00 into adoptium:master Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Rerun failed jdk test cases in Grinder with jdk_custom target" didn't set BUILD_LIST
3 participants