Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add null check for log match group #4522

Merged
merged 1 commit into from
Apr 20, 2023
Merged

Add null check for log match group #4522

merged 1 commit into from
Apr 20, 2023

Conversation

renfeiw
Copy link
Contributor

@renfeiw renfeiw commented Apr 19, 2023 •
edited
Loading

Fixes #4520

@renfeiw
Copy link
Contributor Author

renfeiw commented Apr 19, 2023 •
edited
Loading

tested in Grinder_TKG/1880 and with CRIU change: Grinder/32425/

@renfeiw renfeiw marked this pull request as ready for review April 19, 2023 19:50
@renfeiw renfeiw marked this pull request as draft April 19, 2023 19:53
@renfeiw
Add null check for log match group
9ecdbc7 
Signed-off-by: renfeiw <renfeiw@ca.ibm.com>
llxia
llxia approved these changes Apr 20, 2023
View reviewed changes
Copy link
Contributor

@llxia llxia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@renfeiw renfeiw marked this pull request as ready for review April 20, 2023 17:56
LongyuZhang
LongyuZhang approved these changes Apr 20, 2023
View reviewed changes
Copy link
Contributor

@LongyuZhang LongyuZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LongyuZhang LongyuZhang merged commit 48ed774 into adoptium:master Apr 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LongyuZhang LongyuZhang LongyuZhang approved these changes

@llxia llxia llxia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot invoke method split() on null object
3 participants
@renfeiw @llxia @LongyuZhang