-
-
Notifications
You must be signed in to change notification settings - Fork 314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consolidating duplicate excluded tests #4651
Consolidating duplicate excluded tests #4651
Conversation
Duplicates have been removed. Tidying now. |
Duplicates can cause tests to be unexcluded, so I've removed all instances of this by commenting out the duplicates and consolidating the platforms in the non-commented-out exclusion. Plus tidying. Whitespace management, some new lines for uniformity, etc. Signed-off-by: Adam Farley <adfarley@redhat.com>
0d107b8
to
727881b
Compare
@adamfarley Lots of failing test? |
We need to update our workflows (captured in #2299)
Will not block this PR on those failures. (Jenkins Grinder run as a better test for this PR than using run-aqa in a workflow). |
Ok, got a theory vis-a-vis the failures: Looking at a bunch of other PRs in this repo (including this one, which is also an exclude file change), it seems that these tests aren't run for any other PRs. My theory is that, since this PR started out as a WIP PR, it triggered the test jobs (via the github action "Directories/Files Change Test PR") when I took the WIP out of the title and clicked the "ready for review" button. So, in short, I think we should merge this PR as-is, and raise 2 separate issues for the following problems (to be addressed AFTER the release ofc):
Update: Shelley beat me to it. :) |
Commenting out duplicate tests from the exclude files, ensuring the platforms are appended to their unexcluded duplicates, and tidying the targets to help avoid this problem in the future.
See here for details:
#4650