Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add c99 CFLAG option for JDK21 p/zLinux natives #4725

Merged
merged 1 commit into from
Aug 25, 2023
Merged

Add c99 CFLAG option for JDK21 p/zLinux natives #4725

merged 1 commit into from
Aug 25, 2023

Conversation

jdekonin
Copy link
Contributor

@jdekonin jdekonin marked this pull request as draft August 24, 2023 16:49
@jdekonin
Copy link
Contributor Author

I modified the condition to work for jdk21+ using the method that is consistent with how its performed in the rest of the script. Ready for review.

@jdekonin
Add c99 CFLAG option for JDK21 p/zLinux natives
7b282e2 
Signed-off-by: Joe deKoning <joe_dekoning@ca.ibm.com>
llxia
llxia approved these changes Aug 25, 2023
View reviewed changes
Copy link
Contributor

@llxia llxia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jdekonin

@llxia llxia marked this pull request as ready for review August 25, 2023 17:45
@llxia llxia requested a review from LongyuZhang August 25, 2023 17:45
LongyuZhang
LongyuZhang approved these changes Aug 25, 2023
View reviewed changes
Copy link
Contributor

@LongyuZhang LongyuZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LongyuZhang LongyuZhang merged commit 78d968b into adoptium:master Aug 25, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LongyuZhang LongyuZhang LongyuZhang approved these changes

@llxia llxia llxia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jdekonin @llxia @LongyuZhang