-
-
Notifications
You must be signed in to change notification settings - Fork 314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include vendor's problem list only if there is one #4791
Conversation
Signed-off-by: Sophia Guo <sophia.gwf@gmail.com>
Delete empty and unnecessary problem list files to reduce confusion Signed-off-by: Sophia Guo <sophia.gwf@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Even though those problems lists are empty, downstream providers may rely on them?
If Vendors do need to exclude tests per their specific reason per JDK they can create directly add the files. |
@karianna - this PR contains a change in openjdk.mk that means empty vendor-specific ProblemList files are no longer needed as placeholders. If downstream vendors have specific tests that need to be excluded, that are not in the common set of ProblemList files applicable to all vendors, then you can add the file back into the vendor specific ProblemList files with an entry in it. It makes no sense for us to force vendors to add empty files in order to run without error, so the change in the openjdk.mk file of the PR fixes that behaviour. |
Close #4790
Signed-off-by: Sophia Guo sophia.gwf@gmail.com