Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include vendor's problem list only if there is one #4791

Merged
merged 2 commits into from
Sep 30, 2023

Conversation

sophia-guo
Copy link
Contributor

Close #4790

Signed-off-by: Sophia Guo sophia.gwf@gmail.com

Signed-off-by: Sophia Guo <sophia.gwf@gmail.com>
Delete empty and unnecessary problem list files to reduce confusion

Signed-off-by: Sophia Guo <sophia.gwf@gmail.com>
@sophia-guo sophia-guo self-assigned this Sep 27, 2023
Copy link
Contributor

@karianna karianna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even though those problems lists are empty, downstream providers may rely on them?

@sophia-guo
Copy link
Contributor Author

Even though those problems lists are empty, downstream providers may rely on them?

If Vendors do need to exclude tests per their specific reason per JDK they can create directly add the files.

@smlambert
Copy link
Contributor

smlambert commented Sep 28, 2023

@karianna - this PR contains a change in openjdk.mk that means empty vendor-specific ProblemList files are no longer needed as placeholders.
Screenshot 2023-09-28 at 10 02 39 AM

If downstream vendors have specific tests that need to be excluded, that are not in the common set of ProblemList files applicable to all vendors, then you can add the file back into the vendor specific ProblemList files with an entry in it. It makes no sense for us to force vendors to add empty files in order to run without error, so the change in the openjdk.mk file of the PR fixes that behaviour.

@karianna karianna merged commit ab604a6 into adoptium:master Sep 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Only includes vendor's openjdk problem list if there is one available.
4 participants