Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ant/unzip: command not found in the error list #4887

Merged
merged 1 commit into from
Nov 22, 2023
Merged

Add ant/unzip: command not found in the error list #4887

merged 1 commit into from
Nov 22, 2023

Conversation

llxia
Copy link
Contributor

@llxia llxia commented Nov 22, 2023 •
edited
Loading

If the error is found in the console output, the node will be marked offline.

related: backlog/issues/983#issuecomment-67423294

@llxia
Copy link
Contributor Author

llxia commented Nov 22, 2023 •
edited
Loading

Grinder
The problematic node is removed, so we cannot test the scenario. The above Grinder is just to ensure this PR does not break anything.

@llxia llxia marked this pull request as ready for review November 22, 2023 21:11
@llxia llxia requested a review from pshipton November 22, 2023 21:11
@pshipton
Copy link
Contributor

Could this be more generic and just look for command not found? Or if that is too scary, we should check for ant: command not found as well, which was another earlier problem we saw.

@llxia
Copy link
Contributor Author

llxia commented Nov 22, 2023

Yes, command not found is too scary. I will add ant: command not found.

@llxia
Add ant/unzip: command not found in the error list
569fb61 
related: backlog/issues/983#issuecomment-67423294

Signed-off-by: Lan Xia <Lan_Xia@ca.ibm.com>
@llxia
Copy link
Contributor Author

llxia commented Nov 22, 2023

PR is updated to include ant: command not found

@llxia llxia changed the title Add unzip: command not found in the error list Add ant/unzip: command not found in the error list Nov 22, 2023
@pshipton pshipton merged commit 5b066b2 into adoptium:master Nov 22, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pshipton pshipton pshipton approved these changes

@smlambert smlambert smlambert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@llxia @pshipton @smlambert