Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SmokeTests LIB_DIR path #5173

Merged
merged 1 commit into from
Mar 25, 2024
Merged

Conversation

LongyuZhang
Copy link
Contributor

- SmokeTests have different LIB_DIR path than normal tests

Signed-off-by: LongyuZhang <longyu.zhang@ibm.com>
@LongyuZhang LongyuZhang marked this pull request as draft March 22, 2024 20:06
@llxia
Copy link
Contributor

llxia commented Mar 25, 2024

The smoke test builds and regular test builds have different path (below). This caused a wrong LIB_DIR in the smoke tests.

For example, the smoke test builds have folder build-scripts/jobs/jdk17u:

/home/jenkins/workspace/build-scripts/jobs/jdk17u/jdk17u-linux-s390x-openj9-IBM_SmokeTests/../../testDependency/lib/jcommander.jar

This PR addresses the LIB_DIR issue for smoke test builds, enabling us to utilize pre-staged libraries. However, it would be preferable to have consistent folder structures across all test builds.

@LongyuZhang LongyuZhang marked this pull request as ready for review March 25, 2024 19:59
@LongyuZhang
Copy link
Contributor Author

Test Links:

  • For pipeline name with SmokeTests (link):
14:35:11  Starting download third party dependent jars
14:35:11  --------------------------------------------
14:35:11  downloading dependent third party jars to /home/jenkins/workspace/build-scripts/jobs/jdk11u/jdk11u-linux-x64-openj9_SmokeTests_longyu/../../../../../testDependency/lib
14:35:11  /home/jenkins/workspace/build-scripts/jobs/jdk11u/jdk11u-linux-x64-openj9_SmokeTests_longyu/../../../../../testDependency/lib/testng.jar exists with correct hash, not downloading
  • Logged onto the machine, dependency jars are in /home/jenkins/testDependency/lib

  • For normal pipeline, e.g. Grinder (hyc 39197), is still the same as previous:
    14:56:18 downloading dependent third party jars to /home/jenkins/workspace/Grinder/../../testDependency/lib

Copy link
Contributor

@llxia llxia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @LongyuZhang

@smlambert smlambert merged commit 906b807 into adoptium:master Mar 25, 2024
1 check passed
LongyuZhang added a commit to LongyuZhang/aqa-tests that referenced this pull request Mar 25, 2024
- SmokeTests have different LIB_DIR path than normal tests

Signed-off-by: LongyuZhang <longyu.zhang@ibm.com>
llxia pushed a commit that referenced this pull request Mar 25, 2024
- SmokeTests have different LIB_DIR path than normal tests

Signed-off-by: LongyuZhang <longyu.zhang@ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants