Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable java/lang/ref/FinalizeOverride.java for Java 8 #5205

Merged
merged 1 commit into from
Apr 9, 2024
Merged

Disable java/lang/ref/FinalizeOverride.java for Java 8 #5205

merged 1 commit into from
Apr 9, 2024

Conversation

JasonFengJ9
Copy link
Contributor

@JasonFengJ9 JasonFengJ9 commented Apr 8, 2024 •
edited
Loading

Disable java/lang/ref/FinalizeOverride.java for Java 8

Exclude java/lang/ref/FinalizeOverride.java for Java 8 as well.

Signed-off-by: Jason Feng fengj@ca.ibm.com

@llxia
Copy link
Contributor

llxia commented Apr 8, 2024

Currently, jdk_lang_ref_FinalizeOverride_j9 is disabled for all versions. See https://github.com/adoptium/aqa-tests/pull/5205/files#diff-d2ae1ce824e94cb07603a5a77c2d8ab3c5b00617153e8d66e54a78a3ccfb4f1dL844-L848
The test will not run regardless we remove <version>11+</version> or not.

Also, the above Grinder ran jdk_lang_1. It contains FinalizeOverride.java. If we want to disable FinalizeOverride.java in jdk_lang. Problem list https://github.com/adoptium/aqa-tests/blob/master/openjdk/excludes/ProblemList_openjdk8-openj9.txt should be updated to contain java/lang/ref/FinalizeOverride.java.

@JasonFengJ9
Disable java/lang/ref/FinalizeOverride.java for Java 8
86f2181 
Exclude java/lang/ref/FinalizeOverride.java for Java 8 as well.

Signed-off-by: Jason Feng <fengj@ca.ibm.com>
@JasonFengJ9
Copy link
Contributor Author

Also, the above Grinder ran jdk_lang_1. It contains FinalizeOverride.java. If we want to disable FinalizeOverride.java in jdk_lang. Problem list https://github.com/adoptium/aqa-tests/blob/master/openjdk/excludes/ProblemList_openjdk8-openj9.txt should be updated to contain java/lang/ref/FinalizeOverride.java.

Thanks @llxia , yeah, this is the test to be excluded.
Updated the PR and re-launch another internal grinder.

@JasonFengJ9 JasonFengJ9 changed the title Disable jdk_lang_ref_FinalizeOverride_j9 test for Java 8 Disable java/lang/ref/FinalizeOverride.java for Java 8 Apr 8, 2024
LongyuZhang
LongyuZhang approved these changes Apr 9, 2024
View reviewed changes
Copy link
Contributor

@LongyuZhang LongyuZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LongyuZhang LongyuZhang merged commit f67688d into adoptium:master Apr 9, 2024
2 checks passed
@JasonFengJ9 JasonFengJ9 deleted the finalizetimeoutjdk8 branch April 9, 2024 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LongyuZhang LongyuZhang LongyuZhang approved these changes

@llxia llxia llxia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JasonFengJ9 @llxia @LongyuZhang