Excluding Test8009761 because it needs a backported fix #5228
Conversation
Upstream bug JDK-8021775 changed this test in JDK9+ to include a 1+/- tolerance on the failing variable. This fix was meant to be backported 10 years ago, but seems to have been forgotten about. I've made sure that the associasted Adoptium issue is tagged for an upcoming iteration, so we will be reminded to backport this fix after the April release. Signed-off-by: Adam Farley <adfarley@redhat.com>
|
Linked to issue #5221, but does not resolve it. |
| @@ -27,6 +27,7 @@ compiler/tiered/Level2RecompilationTest.java https://github.com/adoptium/aqa-tes | |||
| # compiler/6894807/IsInstanceTest.java https://github.com/adoptium/adoptium/issues/58 aix-all | |||
| compiler/6894807/IsInstanceTest.java https://github.com/adoptium/aqa-tests/issues/2818 aix-all | |||
| compiler/8004051/Test8004051.java https://github.com/adoptium/aqa-tests/issues/2818 aix-all | |||
| compiler/8009761/Test8009761.java https://github.com/adoptium/aqa-tests/issues/5221 linux-ppc64le | |||
There was a problem hiding this comment.
Is there an upstream open issue like https://bugs.openjdk.org/browse/JDK-8021775 pointing to the issue on jdk8?
If so, then please use that issue instead of 5221 as the referring issue.
If not we ultimately should raise it and refer to it (and ultimately this test excluded upstream). In the meantime, we can bring this change in.
There was a problem hiding this comment.
Is there an upstream open issue like https://bugs.openjdk.org/browse/JDK-8021775 pointing to the issue on jdk8?
I searched, and didn't find an open upstream issue. There was one for the backport 10 years back, but it got deferred to JDK8u20, and (it appears) completely forgotten.
Lots of Test8009761 issues, but they're all closed or resolved.
If so, then please use that issue instead of 5221 as the referring issue. If not we ultimately should raise it and refer to it (and ultimately this test excluded upstream).
Agreed. I left a note for myself here, to be actioned after the release.
In the meantime, we can bring this change in.
👍
Upstream bug JDK-8021775 changed this test in JDK9+ to include a 1+/- tolerance on the failing variable.
This fix was meant to be backported 10 years ago, but seems to have been forgotten about.
I've made sure that the associated Adoptium issue is tagged for an upcoming iteration, so we will be reminded to backport this fix after the April release.
P.S. A cherry-picked branch for the release branch has been prepared, as advised in my previous PR here.