-
-
Notifications
You must be signed in to change notification settings - Fork 314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove set -eo pipefail #5296
remove set -eo pipefail #5296
Conversation
Signed-off-by: Lan Xia <Lan_Xia@ca.ibm.com>
reran on the failed machine: https://ci.adoptium.net/view/Test_grinder/job/Grinder/9891/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
In addition, this PR is wrong. The message clearly says "set: Illegal option -o pipefail" so this PR should have remove only Seeing also the @llxia - please update your systems. You have to be run exceptionally legacy configurations, and it is enforcing breaking changes for everybody else. In addition, the https://github.com/llxia/openjdk-tests/blob/cb86453541d2cedb78dab55e0dac63905c14ad6d/scripts/testenv/testenvSettings.sh do not have isngle pipe so
would be very correct fix. But
Thus removing whole -e is usualy very bad fix. Please revert if you can. |
Thanks @judovana . Please feel free to open an Adoptium infra issue for updating the system. |
Then at least return the |
Signed-off-by: Lan Xia <Lan_Xia@ca.ibm.com>
Signed-off-by: Lan Xia <Lan_Xia@ca.ibm.com>
This does not work on some machines.
fixes: #5295