Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separate hotspot_custom test for j9 #5493

Merged
merged 1 commit into from
Aug 13, 2024
Merged

Separate hotspot_custom test for j9 #5493

merged 1 commit into from
Aug 13, 2024

Conversation

LongyuZhang
Copy link
Contributor

Separate hotspot_custom and hotspot_custom_j9 tests

Issue: #5491

@LongyuZhang
Copy link
Contributor Author

LongyuZhang commented Aug 7, 2024 •
edited
Loading

Test Link:
**hotspot: hotspot_custom **

openj9: hotspot_custom_j9

  • with target serviceability/jvmti/GetSystemProperty/JvmtiGetSystemPropertyTest.java
    21: hyc_grinder 42629
    23: hyc_grinder 42630
  • no CUSTOM_TARGET using default:
    21: hyc_grinder 42628
    23: hyc_grinder 42631

sophia-guo
sophia-guo previously requested changes Aug 8, 2024
View reviewed changes
openjdk/playlist.xml Show resolved Hide resolved
@sophia-guo sophia-guo dismissed their stale review August 13, 2024 19:01

no interested

@LongyuZhang
Add hotspot_custom_j9 test
255590e 
Add hotspot_custom_j9 test

Signed-off-by: LongyuZhang <longyu.zhang@ibm.com>
smlambert
smlambert approved these changes Aug 13, 2024
View reviewed changes
Copy link
Contributor

@smlambert smlambert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As per the discussion this afternoon, approving, you may want to update openj9 docs regarding the nuance of the use of the hotspot_custom_j9 target.

@smlambert smlambert merged commit e6bb784 into adoptium:master Aug 13, 2024
3 checks passed
This was referenced Aug 14, 2024
Closed
Closed
llxia pushed a commit to llxia/aqa-tests that referenced this pull request Aug 14, 2024
@LongyuZhang @llxia
Add hotspot_custom_j9 test (adoptium#5493)
01c8aca 
Add hotspot_custom_j9 test

Signed-off-by: LongyuZhang <longyu.zhang@ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@llxia llxia llxia approved these changes

@sophia-guo sophia-guo sophia-guo left review comments

@smlambert smlambert smlambert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@LongyuZhang @smlambert @sophia-guo @llxia