Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add note about needing ITW to run Jenkins Agent #1825

Merged
merged 2 commits into from
Jan 14, 2021

Conversation

Willsparker
Copy link
Contributor

ref: #1773 , https://adoptopenjdk.slack.com/archives/C53GHCXL4/p1610356948467700, #1818

  • commit message has one of the standard prefixes
  • other documentation is changed or added (if applicable)

Adding a note that IcedTea-Web is needed to run .jnlp files- It's tripped me up, and it has other people as well, so I feel it's necessary to mention.

Copy link
Member

@sxa sxa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion to improve references for those who aren't familiar with ITW

ansible/playbooks/AdoptOpenJDK_Windows_Playbook/README.md Outdated Show resolved Hide resolved
Co-authored-by: Stewart X Addison <6487691+sxa@users.noreply.github.com>
Copy link
Contributor

@karianna karianna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@Haroon-Khel Haroon-Khel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Willsparker Willsparker requested a review from sxa January 12, 2021 13:02
@sxa sxa merged commit d2fcaf8 into adoptium:master Jan 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants