Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker: Docker image tag must be lowercase when building dockerstatic image #3681

Merged
merged 1 commit into from
Aug 1, 2024

Conversation

Haroon-Khel
Copy link
Contributor

@Haroon-Khel Haroon-Khel commented Jul 31, 2024

  • commit message has one of the standard prefixes
  • faq.md updated if appropriate
  • other documentation is changed or added (if applicable)
  • playbook changes run through VPC or QPC (if you have access)
  • VPC/QPC not applicable for this PR
  • for inventory.yml changes, bastillion/nagios/jenkins updated accordingly

Fixes this error ["ERROR: invalid tag \"aqa_u2404.ARM32\": repository name must be lowercase"]

Copy link
Member

@sxa sxa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the | upper necessary when we've fixed the arm32_suffix to be lower case?
If not, I'd be tempted to leave it out in order to avoid any potential confusion with "masking" incorrect values in the automation.

@Haroon-Khel
Copy link
Contributor Author

Is the | upper necessary when we've fixed the arm32_suffix to be lower case?
If not, I'd be tempted to leave it out in order to avoid any potential confusion with "masking" incorrect values in the automation.

The arm32 suffix needs to be lowercase in the build image tag only, so only during the docker build command. I've used the | upper convention when naming the container in the docker run command as I dont think docker cares about upper/lower case when naming the actual running container, just the image tag

Copy link
Member

@sxa sxa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense - thanks.

@karianna karianna merged commit 96163b0 into adoptium:master Aug 1, 2024
12 checks passed
@Haroon-Khel Haroon-Khel deleted the arm32.dockerstatic.fix branch August 1, 2024 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants