Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport support for Alpine musl #7

Merged
merged 5 commits into from
Oct 8, 2021
Merged

Backport support for Alpine musl #7

merged 5 commits into from
Oct 8, 2021

Conversation

calderast
Copy link

Apply Bellsoft's patches (by @voitylov) with the addition of a small fix for execinfo for Alpine musl build support on jdk11u. Described in issue #4
Passed all tests https://ci.adoptopenjdk.net/job/jdk11-alpine-linux-x64-hotspot/4/

karianna
karianna approved these changes Oct 8, 2021
View reviewed changes
Copy link
Contributor

@karianna karianna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - I did think about asking for more documentation within the code (for future engineers that aren't familiar with musl) but the better strategy is to work with Bellsoft upstream on those suggestions to avoid future merge conflicts.

@gdams gdams merged commit 936b0bd into adoptium:release Oct 8, 2021
@llamahunter llamahunter mentioned this pull request Oct 8, 2021
Closed
@basil basil mentioned this pull request May 26, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gdams gdams gdams approved these changes

@karianna karianna karianna approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@calderast @karianna @gdams