Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SharedClassesCacheChecker deletes non-test related caches from default location #73

Closed
Mesbah-Alam opened this issue Jan 17, 2019 · 1 comment

Comments

@Mesbah-Alam
Copy link
Contributor

If default location is used for generating test specific SC caches, SharedClassesCacheChecker has the potential to delete non-test related caches as it iterates through the default location and deletes all caches it finds.

Example:

https://ci.eclipse.org/openj9/job/Test-extended.system-JDK8-win_x86-64_cmprssptrs/139/tapResults/

SCC stderr Details for Cache 5
SCC stderr 
SCC stderr Jan 17, 2019 8:22:07 AM net.openj9.sc.api.SharedClassesCacheChecker verify
SCC stderr INFO: cache name is sharedcc_LOCAL SERVICE

The only test that uses SharedClassesCacheChecker is SharedClassesAPI test. We need to update the test to invoke SharedClassesCacheChecker in such a way that, when default cacheDir is used, it only deletes the cache that the test created.

@Mesbah-Alam
Copy link
Contributor Author

Note: SharedClassesCacheChecker is invoked per cache, so we can simply pass the cacheName to it and force it to only delete that cache-- be it from default cacheDir, or specific cacheDir.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant