Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only destroy test specific caches at setup and teardown of SCC tests #71

Merged
merged 1 commit into from
Jan 17, 2019
Merged

Only destroy test specific caches at setup and teardown of SCC tests #71

merged 1 commit into from
Jan 17, 2019

Conversation

Mesbah-Alam
Copy link
Contributor

Only destroy test specific caches at setup and teardown of tests
Signed-off-by: Mesbah_Alam@ca.ibm.com Mesbah_Alam@ca.ibm.com

@Mesbah-Alam
Copy link
Contributor Author

Related: #62

@Mesbah-Alam Mesbah-Alam mentioned this pull request Jan 15, 2019
Closed
@Mesbah-Alam Mesbah-Alam force-pushed the fixSCCDeletaionIssue branch 3 times, most recently from 274074c to d714467 Compare January 15, 2019 22:28
@Mesbah-Alam
Copy link
Contributor Author

Mesbah-Alam commented Jan 15, 2019 •
edited
Loading

Watching following test builds:
SharedClasses_Workload: https://ci.adoptopenjdk.net/view/Test_grinder/job/Grinder/825/
SharedClassesAPI: https://ci.adoptopenjdk.net/view/Test_grinder/job/Grinder/852/
SharedClasses_Softmx_Increase: https://ci.adoptopenjdk.net/view/Test_grinder/job/Grinder/844/
SharedClasses_Softmx_UpDown: https://ci.adoptopenjdk.net/view/Test_grinder/job/Grinder/828/
SharedClasses_Softmx_JitAot: https://ci.adoptopenjdk.net/view/Test_grinder/job/Grinder/842/
SharedClasses.SCM01.SingleCL: https://ci.adoptopenjdk.net/view/Test_grinder/job/Grinder/849/

@Mesbah-Alam Mesbah-Alam force-pushed the fixSCCDeletaionIssue branch 6 times, most recently from b83913c to cbe0401 Compare January 16, 2019 18:57
@Mesbah-Alam
Only destroy test specific caches at setup and teardown of tests
4436359 
Signed-off-by: Mesbah_Alam@ca.ibm.com <Mesbah_Alam@ca.ibm.com>
@Mesbah-Alam
Copy link
Contributor Author

Mesbah-Alam commented Jan 17, 2019 •
edited
Loading

@pshipton - This PR updates all the Shared Classes tests to destroy only the test related caches at setup and teardown stages. I've verified it based by running specific tests in Grinder at Adopt (links abbove). Could you please review and merge it?

@Mesbah-Alam Mesbah-Alam changed the title Only destroy test specific caches at setup and teardown of tests Only destroy test specific caches at setup and teardown of SCC tests Jan 17, 2019
pshipton
pshipton reviewed Jan 17, 2019
View reviewed changes
...9.test.sharedClasses.jvmti/src/test.sharedClasses.jvmti/net/openj9/stf/SharedClassesAPI.java
//We are running 5 Workloads namely WL1,..WL4. Each creates its own cache, so we should clean up each one of them
for (Tests apiTest : Tests.values()) {
for (int i = 1 ; i < 5 ; i++) {
String cacheName = apiTest.name() + "WL1" + i;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally the number of iterations and the cache name should be shared with the test and not hard coded separately. That way if the tests changes, the cleanup continues to be correct.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree. I'll fix this in a separate PR.

@pshipton pshipton merged commit 5c0eb6c into adoptium:master Jan 17, 2019
@pshipton
Copy link
Contributor

Started a test build https://ci.eclipse.org/openj9/view/Pipelines/job/Pipeline-Release-Build/20/

@Mesbah-Alam
Copy link
Contributor Author

Mesbah-Alam commented Jan 17, 2019 •
edited
Loading

This PR does not solve cache clean up required in SharedClassesAPI test properly. Details in: #73

@pshipton pshipton mentioned this pull request Jan 18, 2019
Open
@Mesbah-Alam Mesbah-Alam deleted the fixSCCDeletaionIssue branch March 20, 2019 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pshipton pshipton pshipton approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Mesbah-Alam @pshipton