fix: more linter

adoptium · May 13, 2022 · acb91d2 · acb91d2
1 parent 0dc8abf
commit acb91d2
Showing 1 changed file with 7 additions and 8 deletions.
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
@@ -1,4 +1,3 @@
-# shellcheck disable=SC2006,SC2086
 name: Build
 
 on:
@@ -79,7 +78,7 @@ jobs:
     - name: Set root of jdk image dir
       run: |
         imageroot=$(find "${HOME}/JDK" -name release -type f)
-        echo "TEST_JDK_HOME=`dirname ${imageroot}`" >> $GITHUB_ENV
+        echo "TEST_JDK_HOME=$(dirname "${imageroot}")" >> $GITHUB_ENV
     - name: Smoke test
       uses: adoptium/run-aqa@v1
       with:
@@ -156,7 +155,7 @@ jobs:
     - name: Set root of jdk image dir
       run: |
         imageroot=$(find "${HOME}/JDK" -name release -type f)
-        echo "TEST_JDK_HOME=`dirname ${imageroot}`" >> $GITHUB_ENV
+        echo "TEST_JDK_HOME=${dirname "${imageroot}")" >> "$GITHUB_ENV"
     - name: Smoke test
       uses: adoptium/run-aqa@v1
       with:
@@ -227,18 +226,18 @@ jobs:
      - name: Cygwin git configuration
        shell: bash
        # workaround for https://github.com/actions/checkout/issues/760
-       run: mkdir $HOME && git config --system core.autocrlf false && git config --global --add safe.directory "$GITHUB_WORKSPACE"
+       run: mkdir $HOME && git config --system core.autocrlf false && git config --global --add safe.directory "${GITHUB_WORKSPACE}"
 
      - uses: actions/checkout@v2
 
      - name: Setup 8dot3name
        run: fsutil behavior set disable8dot3 0
 
      - name: Set JAVA_HOME
-       run: echo "JAVA_HOME=$(cygpath ${{ steps.setup-java11.outputs.path }})" | Out-File -FilePath $env:GITHUB_ENV -Encoding utf8 -Append
+       run: echo "JAVA_HOME=$(cygpath "${{ steps.setup-java11.outputs.path }}")" | Out-File -FilePath "$env:GITHUB_ENV" -Encoding utf8 -Append
 
      - name: Set JDK7_BOOT_DIR
-       run: echo "JDK7_BOOT_DIR=$(cygpath ${{ steps.setup-java7.outputs.path }})" | Out-File -FilePath $env:GITHUB_ENV -Encoding utf8 -Append
+       run: echo "JDK7_BOOT_DIR=$(cygpath "${{ steps.setup-java7.outputs.path }}")" | Out-File -FilePath "$env:GITHUB_ENV" -Encoding utf8 -Append
        if: matrix.version == 'jdk8u'
 
      - name: Build Windows
@@ -269,8 +268,8 @@ jobs:
 
      - name: Set root of jdk image dir
        run: |
-         $imageroot = find ${HOME}/${{matrix.version}}-${{matrix.os}}-${{matrix.vm}} -name release -type f
-         echo "TEST_JDK_HOME=$(dirname ${imageroot})" | Out-File -FilePath $env:GITHUB_ENV -Encoding utf8 -Append
+         imageroot=$(find "${HOME}/${{matrix.version}}-${{matrix.os}}-${{matrix.vm}}" -name release -type f)
+         echo "TEST_JDK_HOME=$(dirname "${imageroot}")" | Out-File -FilePath "$env:GITHUB_ENV" -Encoding utf8 -Append
      - name: Smoke test
        uses: adoptium/run-aqa@v1
        with: