Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update FAQ to account for #2463 #2506

Merged
merged 1 commit into from
Mar 3, 2021
Merged

Update FAQ to account for #2463 #2506

merged 1 commit into from
Mar 3, 2021

Conversation

M-Davies
Copy link
Contributor

@M-Davies M-Davies commented Mar 1, 2021

Signed-off-by: Morgan Davies morgandavies2020@gmail.com

@M-Davies M-Davies added enhancement Issues that enhance the code or documentation of the repo in any way documentation Issues that request updates to our documentation labels Mar 1, 2021
@M-Davies M-Davies added this to the March 2021 milestone Mar 1, 2021
@M-Davies M-Davies requested review from karianna, sxa and gdams March 1, 2021 18:42
@M-Davies M-Davies mentioned this pull request Mar 1, 2021
Merged
sxa
sxa approved these changes Mar 1, 2021
View reviewed changes
Copy link
Member

@sxa sxa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just had a quick glance through but it looks ok to me

@M-Davies
Update FAQ to account for adoptium#2463
5683988 
* Twin PR for ci-jenkins-pipelines:
adoptium/ci-jenkins-pipelines#67

Signed-off-by: Morgan Davies <morgandavies2020@gmail.com>
@M-Davies M-Davies merged commit 12c66cd into adoptium:master Mar 3, 2021
@M-Davies M-Davies mentioned this pull request Mar 5, 2021
Open
M-Davies added a commit to M-Davies/openjdk-build that referenced this pull request Mar 5, 2021
@M-Davies
Expand config parameter location explanation
530f3fa 
* Further explains how and where shell script parameters should be injected
* Follow on from adoptium#2506
* Part 2 of adoptium#2129

Signed-off-by: Morgan Davies <morgandavies2020@gmail.com>
@M-Davies M-Davies mentioned this pull request Mar 5, 2021
Merged
M-Davies added a commit that referenced this pull request Mar 10, 2021
@M-Davies @sxa
Expand config parameter location explanation (#2518)
8b51068 
* Expand config parameter location explanation

* Further explains how and where shell script parameters should be injected
* Follow on from #2506
* Part 2 of #2129

Signed-off-by: Morgan Davies <morgandavies2020@gmail.com>
Co-authored-by: Stewart X Addison <6487691+sxa@users.noreply.github.com>
@M-Davies M-Davies deleted the jenkins_docs branch April 30, 2021 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sxa sxa sxa approved these changes

@andrew-m-leonard andrew-m-leonard andrew-m-leonard approved these changes

@karianna karianna Awaiting requested review from karianna

@gdams gdams Awaiting requested review from gdams

Assignees
No one assigned
Labels
documentation Issues that request updates to our documentation enhancement Issues that enhance the code or documentation of the repo in any way
Projects
None yet
Milestone
March 2021
Development

Successfully merging this pull request may close these issues.
3 participants
@M-Davies @sxa @andrew-m-leonard