Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some fixes for Windows comparable build script #3471

Merged
merged 1 commit into from
Sep 5, 2023
Merged

Some fixes for Windows comparable build script #3471

merged 1 commit into from
Sep 5, 2023

Conversation

andrew-m-leonard
Copy link
Contributor

Some fixes for comparable build script on Windows

  • signtool needs picking up from PATH as location depends on local MSVS dev environment
  • expandJDK was leaving the original files after expanding
  • SELF_CERT not needed as script creates its own now

@andrew-m-leonard
Some fixes for Windows comparable build script
ad90794 
Signed-off-by: Andrew Leonard <anleonar@redhat.com>
@andrew-m-leonard andrew-m-leonard self-assigned this Sep 5, 2023
adamfarley
adamfarley approved these changes Sep 5, 2023
View reviewed changes
Copy link
Contributor

@adamfarley adamfarley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrew-m-leonard andrew-m-leonard merged commit fe5f881 into adoptium:master Sep 5, 2023
23 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamfarley adamfarley adamfarley approved these changes

@gdams gdams gdams approved these changes

Assignees

@andrew-m-leonard andrew-m-leonard

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andrew-m-leonard @gdams @adamfarley