Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

40 implement a secure key storage functionality for the pop server #176

Draft
wants to merge 37 commits into
base: main
Choose a base branch
from
Draft

40 implement a secure key storage functionality for the pop server #176

wants to merge 37 commits into from
+809 −112

Conversation

Tekum-Emmanuella
Copy link
Collaborator

No description provided.

@Tekum-Emmanuella Tekum-Emmanuella linked an issue Sep 24, 2024 that may be closed by this pull request
implement a secure key storage functionality for the pop-server E3 #40
Open
@Tekum-Emmanuella Tekum-Emmanuella requested review from Hermann-Core and Christiantyemele and removed request for Hermann-Core September 24, 2024 14:07
Christiantyemele
Christiantyemele requested changes Sep 25, 2024
View reviewed changes
Copy link
Collaborator

@Christiantyemele Christiantyemele left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not use the existing keystore error enum, and also we have to many errors now it will be better to place the errors in a different file

Christiantyemele
Christiantyemele previously requested changes Sep 25, 2024
View reviewed changes
crates/keystore/src/lib.rs Outdated Show resolved Hide resolved
Hermann-Core
Hermann-Core previously requested changes Sep 26, 2024
View reviewed changes
crates/keystore/Cargo.toml Outdated Show resolved Hide resolved
crates/keystore/src/errors.rs Outdated Show resolved Hide resolved
crates/keystore/src/lib.rs Outdated Show resolved Hide resolved
crates/keystore/src/lib.rs Outdated Show resolved Hide resolved
crates/keystore/src/lib.rs Outdated Show resolved Hide resolved
crates/keystore/src/lib.rs Show resolved Hide resolved
crates/keystore/src/lib.rs Outdated Show resolved Hide resolved
@Christiantyemele Christiantyemele removed the request for review from Blindspot22 October 7, 2024 15:12
@Christiantyemele
Copy link
Collaborator

@Hermann-Core , @IngridPuppet do you think this ticket should be continued ?

Christiantyemele

This comment was marked as outdated.

Sign in to view

@Blindspot22

This comment was marked as outdated.

Sign in to view
@Blindspot22 Blindspot22 removed the request for review from Hermann-Core November 14, 2024 15:08
@Christiantyemele Christiantyemele self-assigned this Nov 19, 2024
@Christiantyemele
Merge remote-tracking branch 'origin/main' into 40-implement-a-secure…
7240052 
…-key-storage-functionality-for-the-pop-server
@chendiblessing chendiblessing marked this pull request as draft November 20, 2024 15:17
@Blindspot22 Blindspot22 requested review from ndefokou and removed request for Christiantyemele November 27, 2024 07:15
@Blindspot22 Blindspot22 added enhancement New feature or request help wanted Extra attention is needed labels Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hermann-Core Hermann-Core Hermann-Core left review comments

@Blindspot22 Blindspot22 Blindspot22 approved these changes

@Christiantyemele Christiantyemele Christiantyemele left review comments

@IngridPuppet IngridPuppet Awaiting requested review from IngridPuppet

@francis-pouatcha francis-pouatcha Awaiting requested review from francis-pouatcha

@ndefokou ndefokou Awaiting requested review from ndefokou

At least 1 approving review is required to merge this pull request.

Assignees

@Hermann-Core Hermann-Core

@Christiantyemele Christiantyemele

@Blindspot22 Blindspot22

Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

implement a secure key storage functionality for the pop-server E3
4 participants
@Tekum-Emmanuella @Christiantyemele @Blindspot22 @Hermann-Core