-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
231 discover feature protocol #236
Conversation
|
Protocols should be separate and not directly communicate with each other. We need a method to identify supported protocols. Currently, we have a couple of solutions:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will approve these after the conflicts have been solved.
crates/web-plugins/didcomm-messaging/protocols/discover-features/src/constant.rs
Outdated
Show resolved
Hide resolved
crates/web-plugins/didcomm-messaging/protocols/discover-features/src/handler.rs
Outdated
Show resolved
Hide resolved
crates/web-plugins/didcomm-messaging/protocols/discover-features/src/handler.rs
Outdated
Show resolved
Hide resolved
crates/web-plugins/didcomm-messaging/protocols/discover-features/src/handler.rs
Outdated
Show resolved
Hide resolved
crates/web-plugins/didcomm-messaging/protocols/discover-features/src/handler.rs
Outdated
Show resolved
Hide resolved
crates/web-plugins/didcomm-messaging/protocols/discover-features/src/handler.rs
Outdated
Show resolved
Hide resolved
crates/web-plugins/didcomm-messaging/protocols/discover-features/src/handler.rs
Outdated
Show resolved
Hide resolved
crates/web-plugins/didcomm-messaging/protocols/discover-features/src/handler.rs
Outdated
Show resolved
Hide resolved
crates/web-plugins/didcomm-messaging/protocols/discover-features/src/handler.rs
Show resolved
Hide resolved
crates/web-plugins/didcomm-messaging/protocols/discover-features/src/errors.rs
Outdated
Show resolved
Hide resolved
crates/web-plugins/didcomm-messaging/protocols/discover-features/src/handler.rs
Outdated
Show resolved
Hide resolved
crates/web-plugins/didcomm-messaging/protocols/discover-features/src/handler.rs
Outdated
Show resolved
Hide resolved
crates/web-plugins/didcomm-messaging/protocols/discover-features/src/handler.rs
Outdated
Show resolved
Hide resolved
crates/web-plugins/didcomm-messaging/protocols/discover-features/src/handler.rs
Outdated
Show resolved
Hide resolved
crates/web-plugins/didcomm-messaging/protocols/discover-features/src/handler.rs
Outdated
Show resolved
Hide resolved
crates/web-plugins/didcomm-messaging/protocols/discover-features/src/handler.rs
Outdated
Show resolved
Hide resolved
crates/web-plugins/didcomm-messaging/protocols/discover-features/src/handler.rs
Outdated
Show resolved
Hide resolved
crates/web-plugins/didcomm-messaging/protocols/discover-features/src/handler.rs
Show resolved
Hide resolved
Please merge the main branch to yours. |
…into 231-discover-feature-protocol
This is a discussion
As from the spec here: we will need to have a way to know in real time what protocols our mediator supports and is willing to disclose, From our previous disscussion i think we brought out a way which could help, were we said the protocols will be loaded in a hashmap, i thought of search for the protocols to disclosed in that hashmap, I am not a 100% sure its the best way to it but for now its the only way i see, But i will need to collaborate with @Hermann-Core and @ndefokou if that be the case.
Right now i have done a version taking aside the above suggestion and used a mock, but i'ld still like the implementation to be checked
Emphasise should'nt be laid on the test for now its not complete !