Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

231 discover feature protocol #236

Merged
merged 15 commits into from
Nov 25, 2024
Merged

Conversation

Christiantyemele
Copy link
Collaborator

@Christiantyemele Christiantyemele commented Nov 6, 2024

This is a discussion

As from the spec here: we will need to have a way to know in real time what protocols our mediator supports and is willing to disclose, From our previous disscussion i think we brought out a way which could help, were we said the protocols will be loaded in a hashmap, i thought of search for the protocols to disclosed in that hashmap, I am not a 100% sure its the best way to it but for now its the only way i see, But i will need to collaborate with @Hermann-Core and @ndefokou if that be the case.
Right now i have done a version taking aside the above suggestion and used a mock, but i'ld still like the implementation to be checked

Emphasise should'nt be laid on the test for now its not complete !

@Christiantyemele Christiantyemele linked an issue Nov 6, 2024 that may be closed by this pull request
@Christiantyemele
Copy link
Collaborator Author

_ No description provided. _

@Christiantyemele Christiantyemele requested review from Hermann-Core, IngridPuppet and Blindspot22 and removed request for IngridPuppet November 8, 2024 08:14
@Hermann-Core
Copy link
Collaborator

As from the spec here: we will need to have a way to know in real time what protocols our mediator supports and is willing to disclose, From our previous disscussion i think we brought out a way which could help, were we said the protocols will be loaded in a hashmap, i thought of search for the protocols to disclosed in that hashmap, I am not a 100% sure its the best way to it but for now its the only way i see, But i will need to collaborate with @Hermann-Core and @ndefokou if that be the case.

Protocols should be separate and not directly communicate with each other. We need a method to identify supported protocols. Currently, we have a couple of solutions:

  • Reading the manifest file of the didcomm-messaging plugin to get the declared features, although:
    • It doesn't provide the versions of the supported protocols.
    • Some protocols may be intentionally omitted during the loading of the mediator server.
  • Adding the collected protocols into the AppState, thus, the handler can access and identify the mounted protocols.

Copy link
Collaborator

@Blindspot22 Blindspot22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will approve these after the conflicts have been solved.

@adorsys adorsys deleted a comment from Hermann-Core Nov 14, 2024
@Hermann-Core
Copy link
Collaborator

Please merge the main branch to yours.

@Christiantyemele Christiantyemele merged commit f893480 into main Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Discover Feature protocol
3 participants